Move exercises to subdirectory. Fixes #223 #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, though I guess you could let someone look at it again after rebasing. All I really did here though was see that all the exercise dirs got moved and no dirs got moved that shouldn't have. I'm trusting y'all on the API allowing |
kytrinyx
force-pushed
the
exercises-subdir
branch
from
14589b2 to
d895e12
Compare
|
Rebased. |
|
Seems good to me. I think the build failure is a transient one? I don't know how to get travis to retry though. (Usually I just make an inconsequential change in my commit message and push again, that gets a retry going) |
|
There's a 'restart build' button in travis that you should have access to (upper right corner).
|
|
I kicked it off again. We'll see. |
|
Confirmed I see that button. Guess the light coloring means I don't see it unless I know where to look for it. OK then. |
|
Now it's a different one that broke. what the heck? |
So it's stalling. It might just be graemlins in the travis CI system. |
|
And green. OK, I think we're good to go. |
petertseng
added a commit
that referenced
this pull request
Jan 22, 2016
Move exercises to subdirectory. Fixes #223
robphoenix
pushed a commit
to robphoenix/exercism-go
that referenced
this pull request
Jan 16, 2017
the filepath needed used by example_gen.go was changed in exercism#224 the test cases were changed in this commit: exercism/problem-specifications#463
robphoenix
pushed a commit
to robphoenix/exercism-go
that referenced
this pull request
Jan 16, 2017
the filepath needed used by example_gen.go was changed in exercism#224 the test cases were changed in this commit: exercism/problem-specifications#463
robphoenix
pushed a commit
to robphoenix/exercism-go
that referenced
this pull request
Jan 16, 2017
the filepath used by example_gen.go was changed in exercism#224 README details on generating tests also updated to reflect moving exercises into exercises subdirectory
robphoenix
pushed a commit
to robphoenix/exercism-go
that referenced
this pull request
Jan 16, 2017
fixes exercism#357 Since the re-organised exercises directory (exercism#224) the test generator filepaths have been broken. This commit changes `gen.Gen` to take care of locating the `canonical-data.json` file, allowing each exercises `example_gen.go` file to just pass in the exercise name. This should also help with any future changes that affect the filepaths.
robphoenix
pushed a commit
to robphoenix/exercism-go
that referenced
this pull request
Jan 16, 2017
the filepath needed used by example_gen.go was changed in exercism#224 the test cases were changed in this commit: exercism/problem-specifications#463
robphoenix
pushed a commit
to robphoenix/exercism-go
that referenced
this pull request
Jan 16, 2017
the filepath needed used by example_gen.go was changed in exercism#224 the test cases were changed in this commit: exercism/problem-specifications#463
robphoenix
pushed a commit
to robphoenix/exercism-go
that referenced
this pull request
Jan 17, 2017
the filepath needed used by example_gen.go was changed in exercism#224 the test cases were changed in this commit: exercism/problem-specifications#463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.