Sync: re-write grade-school
#1050
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was a bit involved. The requirements and API changed quite a lot, so I decided to re-write the whole test suite. Here are the main changes I made
map
, but I changed it so that the student may implement whatever@type school
they prefer, and the tests don't assume a specific data structure.School.new/0
.add
used to return aschool
, but the new tests needed to know if a student insertion was allowed, so now it returns{:ok | :error, school}
.:ok | :error
) and the roster separately for the same data.