Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing configlet lint from critical CI path. #439

Merged
merged 7 commits into from
May 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 7 additions & 20 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,12 @@ name: CI
on:
push:
branches:
- master
- main
pull_request:
branches:
- master
- main

jobs:
configuration-test:
name: Check Configuration
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.3.4
- name: Configlet
run: |
bin/fetch-configlet
bin/configlet lint .
bin/check-configlet-fmt.sh
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

linux-min:
name: Linux Min Config
runs-on: ubuntu-16.04
Expand All @@ -44,7 +31,7 @@ jobs:

linux-latest:
name: Linux Latest Config
needs: [linux-min, configuration-test]
needs: [linux-min]
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down Expand Up @@ -74,23 +61,23 @@ jobs:

windows:
name: Windows
needs: [linux-min, configuration-test]
needs: [linux-min]
runs-on: windows-latest
steps:
- uses: actions/checkout@v2.3.4
- name: Run Tests
shell: powershell
# Delete the exercises that require Boost to avoid issues with Windows setup.
run: |
rm exercises/gigasecond -r
rm exercises/meetup -r
rm exercises/practice/gigasecond -r
rm exercises/practice/meetup -r
cmake .
cmake --build . -- test_hello-world
cmake --build .

mac:
name: MacOS
needs: [linux-min, configuration-test]
needs: [linux-min]
runs-on: macOS-latest
steps:
- uses: actions/checkout@v2.3.4
Expand Down
6 changes: 3 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
cmake_minimum_required(VERSION 3.5.1)
project(exercism CXX)

set(alt_exercise_tree ${CMAKE_CURRENT_SOURCE_DIR}/build_exercises)
set(alt_exercise_tree ${CMAKE_CURRENT_SOURCE_DIR}/build_exercises/practice)

function(build_fixup exercise_dir alt_exercise_root)
string(REPLACE "-" "_" file ${exercise_dir})
set(source ${CMAKE_CURRENT_SOURCE_DIR}/exercises/${exercise_dir})
set(source ${CMAKE_CURRENT_SOURCE_DIR}/exercises/practice/${exercise_dir})
if(EXISTS ${source})
set(alt_exercise_dir ${alt_exercise_root}/${exercise_dir})
file(COPY ${source} DESTINATION ${alt_exercise_root})
Expand All @@ -30,7 +30,7 @@ if(EXERCISM_COMMON_CATCH)
)
endif()

file(GLOB exercise_list ${CMAKE_CURRENT_SOURCE_DIR}/exercises/*)
file(GLOB exercise_list ${CMAKE_CURRENT_SOURCE_DIR}/exercises/practice/*)

foreach(exercise_dir ${exercise_list})
get_filename_component(exercise ${exercise_dir} NAME)
Expand Down
22 changes: 21 additions & 1 deletion config.json
Original file line number Diff line number Diff line change
Expand Up @@ -734,5 +734,25 @@
}
],
"key_features": [],
"tags": []
"tags": [
"execution_mode/compiled",
"paradigm/procedural",
"typing/static",
"platform/android",
"platform/ios",
"platform/linux",
"platform/mac",
"platform/windows",
"runtime/language_specific",
"used_for/backends",
"used_for/cross_platform_development",
"used_for/embedded_systems",
"used_for/financial_systems",
"used_for/frontends",
"used_for/games",
"used_for/guis",
"used_for/mobile",
"used_for/robotics",
"used_for/scientific_calculations"
]
}