Skip to content

Adding Practice Exercise Generator #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 7, 2022
Merged

Conversation

PaulT89
Copy link
Contributor

@PaulT89 PaulT89 commented May 4, 2022

Summary

This adds an exercise generator (as a Python script). It also updates the common-lisp/README.md file with instructions on how to use it.

Checklist

  • If docs where changed run ./bin/configlet generate to ensure all documents are properly generated.
  • CI is green

@verdammelt
Copy link
Member

Likely your main branch that you are requesting to be pulled here is out of date to the main branch here in the remote repository. If you update your branch with something like a pull with rebase then you can force push your branch and this PR will be corrected to only contain the correct changes.

Before we go to merge I'd like to make sure it is cleaned up.

Copy link
Member

@verdammelt verdammelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some initial comments. I'll give it a better look and a test hopefully soon.

This adds an exercise generator (as a Python script). It also updates the common-lisp/README.md file with instructions on how to use it.
@PaulT89 PaulT89 reopened this May 5, 2022
Created executable.  Removed references to Python in the README when mentioning the exercise generator - the existence of the executable removes the need for it.
PaulT89 added 2 commits May 6, 2022 02:06
Added CLI functionality as an additional option.  Updated README to reflect this.  Created new executable from updated code.
In list creation, went from using `'(...` to using `(list...` to remove possible problems when creating nested lists.
@verdammelt
Copy link
Member

I have given this a try and it works well in python3. I first had to install toml though, which prompted me to relearn how to use a virtual env so I would not install dependencies globally.

The output has some small issues but I would not expect a generator to work well enough that some review is would not be needed. It seemed to do its job well enough that it might be useful.

The .EXE however is not useful and I suggest removing it. It is built for a particular OS and chipset so will not work on other machines.

PaulT89 added 2 commits May 7, 2022 15:21
Removed the executable.  Updated README to reflect use of Python to run the generator.
Changed generated test equality: equalp -> equal
@verdammelt verdammelt added x:action/create Work on something from scratch x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/generator Work on Exercise generators x:module/practice-exercise Work on Practice Exercises x:size/large Large amount of work labels May 7, 2022
@verdammelt verdammelt merged commit 23240b3 into exercism:main May 7, 2022
@verdammelt
Copy link
Member

Thank you very much @PaulT89 for writing this generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/create Work on something from scratch x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/generator Work on Exercise generators x:module/practice-exercise Work on Practice Exercises x:size/large Large amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants