Support named timezones #2447
Open
Support named timezones #2447
+89
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just UTC+/UTC- offsets, support named timezones. These will adjust for DST correctly.
|
Hi. Basically LGTM. I would like to merge that now, but before one feature is missed - support of current times. It means that if I merge that version it will remove all clocks the user has. I see 2 options: you can add that or I will merge that next week and will make some workaround. PS: also the select box needs to be adjusted to correctly fit the name: 
|
|
I think I've resolved those concerns, although I'm not especially familiar with the UI frameworks. I think that control would also be improved if it was replaced with a text field using autocomplete and validation (rather than a very, very long list), but that seems a little too ambitious for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just UTC+/UTC- offsets, support named timezones. These will adjust for DST correctly.