Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontAwesome !works #858

Open
dylanh724 opened this issue Sep 5, 2024 · 4 comments
Open

FontAwesome !works #858

dylanh724 opened this issue Sep 5, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@dylanh724
Copy link

Describe the bug

context
When I do ___:

FA Test
-------

- An icon :fas:`spinner;sd-text-primary`, some more text.
- An icon :fab:`github`, some more text.
- An icon :fab:`gitkraken;sd-text-success fa-xl`, some more text.
- An icon :fas:`skull;sd-text-danger`, some more text.

expectation
I expected FA icons to appear as shown in the parent PyData doc

bug
But instead no FA icon appears; instead, they appear as an #anchored link that literally shows:

:fab:`github`

image

problem
This is a problem for anyone trying to use FontAwesome.

Reproduce the bug

FA Test

  • An icon :fas:spinner;sd-text-primary, some more text.
  • An icon :fab:github, some more text.
  • An icon :fab:gitkraken;sd-text-success fa-xl, some more text.
  • An icon :fas:skull;sd-text-danger, some more text.

List your environment

  • python 3.10
  • win11
  • sphinx-book-theme 1.1.3
  • sphinx 7.3.7
@dylanh724 dylanh724 added the bug Something isn't working label Sep 5, 2024
@agoose77
Copy link
Collaborator

agoose77 commented Sep 5, 2024

The font-awesome icon roles are defined in sphinx-design, not sphinx-book-theme. Have you installed and enabled it?

@dylanh724
Copy link
Author

The font-awesome icon roles are defined in sphinx-design, not sphinx-book-theme. Have you installed and enabled it?

I have not :) I had no clue it was separate. Is there a doc you can point me to that instructs this? I'm curious how one normally finds this.

@dylanh724
Copy link
Author

(Heads up, the quickstart instructions for sphinx-design is wrong):

https://sphinx-design.readthedocs.io/en/latest/get_started.html

It's pip sphinx_design, not sphinx-design (that seems to exist, but dated)

@dylanh724
Copy link
Author

image

Many thanks, friend. However, I am going to leave this ticket open since this may still be a task. I went back to onboarding looked around similar sections regarding styling, but still couldn't find a direction to what you just told me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants