Text in navigation footer (previous, next) in not translated

[pfelber]

Describe the problem

Hi,

The new navigation footer now has "PREVIOUS" and "NEXT" labels. These labels seem to be hardcoded in the css and are not translated when changing the language of the book. While they can be overridden in the CSS, it might be good to have them generated directly in the book's language (I am using "language: fr").

(As a side note, I preferred the old style with "<<", ">>" and the smaller font.)

Thanks,

Pascal

Link to your repository or website

No response

Steps to reproduce

This problem can be seen in any generated book when setting the language to anything different from English.

The version of Python you're using

No response

Your operating system

No response

Versions of your packages

❯ jupyter-book --version
Jupyter Book      : 0.11.2
External ToC      : 0.2.2
MyST-Parser       : 0.13.7
MyST-NB           : 0.12.3
Sphinx Book Theme : 0.1.1
Jupyter-Cache     : 0.4.2
NbClient          : 0.5.3

Tasks

• Look into the translation function from ✨ NEW: Add translations for all buttons and tooltips #214 to re-use that function
• Confirm that the translation works as expected

[welcome]

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

[chrisjsewell]

Heya, yeh these navigations are inherited from pydata-sphinx-theme:https://github.com/pydata/pydata-sphinx-theme/blob/f0834772d24c962b7d11643114db88615c43674e/pydata_sphinx_theme/layout.html#L4, and so are not currently handled by the translation functionality included in sphinx-book-theme

So either it needs to be "fixed" there (cc @jorisvandenbossche) or we need to override that macro

[choldgraf]

Ah this was actually a recent change in the CSS to add "previous" and "next" (it was inspired from the Furo docs). This makes me think we might want to change the implementation as I doubt CSS can be translated unless we turn it into a _t template, which seems sub-optimal 🤔

here's the CSS where that's defined:

sphinx-book-theme/src/scss/_page.scss

Line 90 in 298502b

.right-next {

[chrisjsewell]

Ah ok yeh no that needs to go in the html templates, so it can be translated

[chrisjsewell]

@choldgraf did you check that #374 actually works, because I don't think it will; you are using sphinx's internal translation function which does not include PREVIOUS/NEXT, rather than using the translation function I set up in #214

[chrisjsewell]

testing in #381

[choldgraf]

ahhh in that case you are right - I didn't realize we needed a separate setup for this. I will keep this on my plate in that case and try to get to it when I have time.

[choldgraf]

I can confirm that the translations do not work. I tried using the translate function and looked at the README docs of the translate folder which seems like it would work, with a few confusion points.

@chrisjsewell what languages did you select when you generated the translations? And after that you just put it in a specific folder and then ran python sphinx_book_theme/translations/_convert.py? I think we need to have a "step by step" guide for adding a new translation to the theme so that it's straightforward to do this. I can try to write this but I need to know the steps first haha.

[chrisjsewell]

what languages did you select when you generated the translations?

all of them

nd after that you just put it in a specific folder and then ran python sphinx_book_theme/translations/_convert.py

yep should be as easy as that

[choldgraf]

I spent a while trying to figure out the translation machinery and was not able to do so. I don't have time to work on this now so instead I've opened up an issue about documenting this infrastructure, and added in my steps that I took in that issue in case others have time to take a look: #382

I'll leave this issue open in the meantime, though removing myself from assignment because I'm not sure when I'll have a moment to work on coding stuff. We might also consider reverting back to just using -> instead of english words, so that we don't have to do the translation stuff.

[choldgraf]

OK I believe that #384 fixed this issue. @pfelber can you install the latest version from master and report back if the translations correctly happen? I will close this issue, but if somebody notices that this didn't correctly fix it, we can re-open

[pfelber]

I verified and translations happen correctly, thanks!