Skip to content

Conversation

@venthur
Copy link
Contributor

@venthur venthur commented Nov 21, 2023

No description provided.

@chrisjsewell
Copy link
Member

chrisjsewell commented Nov 21, 2023

Heya, this won't actually sort them when running pre-commit though, it'll just fail if they are not sorted. You need to set up the ruff formatter and stuff for that

@venthur
Copy link
Contributor Author

venthur commented Nov 21, 2023

Good call. I only use --fix here to fix the linter issues that can be automatically fixed. In case of isort all of them should be fixable, some others might not be, though, and we're running black anyways which should take care of the rest. In principal, you could think about replacing black with ruff as well and go full ruff format .

@chrisjsewell
Copy link
Member

For formatting, you shouldn't have to run anything apart from pre-commit, and it should just do it all

For linting obviously that's not always possible.

Sorting imports is certainly formatting and not linting though

@venthur
Copy link
Contributor Author

venthur commented Nov 21, 2023

Ah ok, i wasn't aware. Feel free to close that PR then. Cheers!

@chrisjsewell
Copy link
Member

Superceded by #313 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants