-
Notifications
You must be signed in to change notification settings - Fork 207
Add paragraph wrapper to table rows #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paragraph wrapper to table rows #128
Conversation
Thanks @martinagvilas looks good (well apart from the currently failing tests lol) Cheers, Chris |
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 91.68% 91.70% +0.01%
==========================================
Files 9 9
Lines 974 976 +2
==========================================
+ Hits 893 895 +2
Misses 81 81
Continue to review full report at Codecov.
|
I fixed the failing tests, but I still have to add the new ones |
I added some tests, let me know if they are enough Also, I noticed that when using |
@martinagvilas amazing! yep, the |
Ta, yes HTML is strictly adherent with markdown-it: |
Great! Just wanted to make sure I wasn't missing anything |
btw @choldgraf you can see here that with |
wooo congrats @martinagvilas on your first pull request merged in the ExecutableBookProject! :-) @chrisjsewell - thanks for pointing it out - I'll just start forking and making PRs that way from now on |
Closes #127
I added a paragraph wrapper to
render_table_row
, and modified the existing tests to capture this wrapper.Let me know if a new test should be added to this PR, making sure urls inside the table are rendered as references, or something of the sort.