Feature/excludes #49
Merged
Feature/excludes #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // check for wildcard match | ||
| for (let key in settings) { | ||
| if (Utils.startsWith(key.toLowerCase(), sourcePrefix.toLowerCase()) && Utils.isMatch(source, [key.substring(sourcePrefix.length)])) { |
There was a problem hiding this comment.
Doesn't seem like this would handle the same wildcard patterns as the .NET client. In the .NET client the pattern can start with an * which will match based on suffix, end with a * which will match based on prefix, start and end with a * which will do a substring match or it can just be a * which will match everything.
There was a problem hiding this comment.
Do you have any unit tests that make sure this is working?
There was a problem hiding this comment.
Yes, Utils.IsMatch does the same thing and we have unit tests for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.