Skip to content

Fixes #25 Add support for stringifying event data with a maxDepth #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Mar 17, 2023
Merged

Fixes #25 Add support for stringifying event data with a maxDepth #127

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
bd4d926
Added tests for #25
niemyjski Mar 1, 2023
255256a
use node 18 watch
niemyjski Mar 5, 2023
602df9b
Bump deps
niemyjski Mar 5, 2023
679f357
Improved stringify tests
niemyjski Mar 5, 2023
111e5f5
Some progress, much more needed.
niemyjski Mar 8, 2023
9e5e484
added test:watch
niemyjski Mar 9, 2023
bd8faa1
Fixed more tests
niemyjski Mar 9, 2023
3289aba
Fixed all prune tests
niemyjski Mar 10, 2023
6e8414d
prune impl before simplification.
niemyjski Mar 10, 2023
3d3a4f3
WIP - Added description of new prune goals
niemyjski Mar 10, 2023
468bb9b
WIP new prune logic
niemyjski Mar 14, 2023
b30deba
Updated deps
niemyjski Mar 16, 2023
1a2a8b5
Added workspace, needed to get jest test runner working
niemyjski Mar 16, 2023
0ba2c45
More prune work
niemyjski Mar 16, 2023
795077a
Added new depth implementation, support for toJSON, support symbol p…
niemyjski Mar 16, 2023
c0ce88e
Fixed prune and stringify tests
niemyjski Mar 17, 2023
8178d2b
Small updates
niemyjski Mar 17, 2023
561cb75
Updated deps
niemyjski Mar 17, 2023
d6afb19
Fixed type assertions
niemyjski Mar 17, 2023
c540469
removed test:watch
niemyjski Mar 17, 2023
a65e7a7
Improved empty checks and added basic tests
niemyjski Mar 17, 2023
1546567
Delete Exceptionless.JavaScript.code-workspace
niemyjski Mar 17, 2023
3e1dac5
fixed unneed assertion
niemyjski Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixed unneed assertion
  • Loading branch information
@niemyjski
niemyjski committed Mar 17, 2023
commit 3e1dac5865fa294735dacad6d913fb60dbf7a22c
2 changes: 1 addition & 1 deletion packages/core/src/EventBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ export class EventBuilder {
const exclusions = this.client.config.dataExclusions.concat(excludedPropertyNames || []);
const json = stringify(value, exclusions, maxDepth);
if (!isEmpty(json)) {
this.target.data[name] = JSON.parse(json as string);
this.target.data[name] = JSON.parse(json);
}

return this;
Expand Down