Merge pull request #35 from exceptionless/feature/deduplication

Implemented DuplicateChecker

Author: niemyjski

dist/exceptionless.d.ts

@@ -326,6 +326,37 @@ export interface IEnvironmentInfo {
     runtime_version?: string;
     data?: any;
 }
+export interface IParameter {
+    data?: any;
+    generic_arguments?: string[];
+    name?: string;
+    type?: string;
+    type_namespace?: string;
+}
+export interface IMethod {
+    data?: any;
+    generic_arguments?: string[];
+    parameters?: IParameter[];
+    is_signature_target?: boolean;
+    declaring_namespace?: string;
+    declaring_type?: string;
+    name?: string;
+    module_id?: number;
+}
+export interface IStackFrame extends IMethod {
+    file_name?: string;
+    line_number?: number;
+    column?: number;
+}
+export interface IInnerError {
+    message?: string;
+    type?: string;
+    code?: string;
+    data?: any;
+    inner?: IInnerError;
+    stack_trace?: IStackFrame[];
+    target_method?: IMethod;
+}
 export declare class ConfigurationDefaultsPlugin implements IEventPlugin {
     priority: number;
     name: string;
@@ -358,36 +389,13 @@ export declare class SubmissionMethodPlugin implements IEventPlugin {
     name: string;
     run(context: EventPluginContext, next?: () => void): void;
 }
-export interface IParameter {
-    data?: any;
-    generic_arguments?: string[];
-    name?: string;
-    type?: string;
-    type_namespace?: string;
-}
-export interface IMethod {
-    data?: any;
-    generic_arguments?: string[];
-    parameters?: IParameter[];
-    is_signature_target?: boolean;
-    declaring_namespace?: string;
-    declaring_type?: string;
-    name?: string;
-    module_id?: number;
-}
-export interface IStackFrame extends IMethod {
-    file_name?: string;
-    line_number?: number;
-    column?: number;
-}
-export interface IInnerError {
-    message?: string;
-    type?: string;
-    code?: string;
-    data?: any;
-    inner?: IInnerError;
-    stack_trace?: IStackFrame[];
-    target_method?: IMethod;
+export declare class DuplicateCheckerPlugin implements IEventPlugin {
+    priority: number;
+    name: string;
+    private recentlyProcessedErrors;
+    run(context: EventPluginContext, next?: () => void): void;
+    private getNow();
+    private checkDuplicate(error, log);
 }
 export interface IError extends IInnerError {
     modules?: IModule[];

dist/exceptionless.js

@@ -7,6 +7,7 @@ import { ModuleInfoPlugin } from './default/ModuleInfoPlugin';
 import { RequestInfoPlugin } from './default/RequestInfoPlugin';
 import { EnvironmentInfoPlugin } from './default/EnvironmentInfoPlugin';
 import { SubmissionMethodPlugin } from './default/SubmissionMethodPlugin';
+import { DuplicateCheckerPlugin } from './default/DuplicateCheckerPlugin';
 
 export class EventPluginManager {
   public static run(context:EventPluginContext, callback:(context?:EventPluginContext) => void): void {
@@ -43,6 +44,7 @@ export class EventPluginManager {
   public static addDefaultPlugins(config:Configuration): void {
     config.addPlugin(new ConfigurationDefaultsPlugin());
     config.addPlugin(new ErrorPlugin());
+    config.addPlugin(new DuplicateCheckerPlugin());
     config.addPlugin(new ModuleInfoPlugin());
     config.addPlugin(new RequestInfoPlugin());
     config.addPlugin(new EnvironmentInfoPlugin());

dist/exceptionless.js.map

@@ -0,0 +1,82 @@
+import { ContextData } from '../ContextData';
+import { EventPluginContext } from '../EventPluginContext';
+import { DuplicateCheckerPlugin } from './DuplicateCheckerPlugin';
+import { ErrorPlugin } from './ErrorPlugin';
+import { createFixture } from './EventPluginTestFixture';
+
+describe('DuplicateCheckerPlugin', () => {
+
+  let target: DuplicateCheckerPlugin;
+  let now: number;
+
+  beforeEach(() => {
+    target = new DuplicateCheckerPlugin();
+    (<any>target).getNow = () => now;
+    now = 0;
+  });
+
+  function run(exception: Error) {
+    let context: EventPluginContext;
+    let contextData: ContextData;
+    ({
+      context,
+      contextData
+    } = createFixture());
+
+    contextData.setException(exception);
+
+    let errorPlugin = new ErrorPlugin();
+    errorPlugin.run(context);
+    target.run(context);
+
+    return context;
+  }
+
+  it('should ignore duplicate within window', () => {
+    let exception = createException([{
+      name: 'methodA'
+    }]);
+    run(exception);
+    let contextOfSecondRun = run(exception);
+    expect(contextOfSecondRun.cancelled).toBeTruthy();
+  });
+
+  it('shouldn\'t ignore error without stack', () => {
+    let exception = createException();
+    run(exception);
+    let contextOfSecondRun = run(exception);
+    expect(contextOfSecondRun.cancelled).toBeFalsy();
+  });
+
+  it('shouldn\'t ignore different stack within window', () => {
+    let exception1 = createException([{
+      name: 'methodA'
+    }]);
+    run(exception1);
+    let exception2 = createException([{
+      name: 'methodB'
+    }]);
+    let contextOfSecondRun = run(exception2);
+    expect(contextOfSecondRun.cancelled).toBeFalsy();
+  });
+
+  it('shouldn\'t ignore duplicate after window', () => {
+    let exception = createException([{
+      name: 'methodA'
+    }]);
+    run(exception);
+
+    now = 3000;
+    let contextOfSecondRun = run(exception);
+    expect(contextOfSecondRun.cancelled).toBeFalsy();
+  });
+});
+
+function createException(stack?) {
+  try {
+    throw new Error();
+  } catch (e) {
+    e.testStack = stack;
+    return e;
+  }
+}