fix: resolve GitHub Actions CI failures and linting issues

- Fix test runner path reference in CI workflow (scripts/test_runner.go -> test_runner.go)
- Fix unused parameter linting warnings across multiple files
- Fix unchecked error returns (errcheck) in test files and app logic
- Fix error string formatting issues (remove capitalization and punctuation)
- Fix code flow issues (remove superfluous else statements)

Author: exceptioncoding

.github/workflows/ci.yml

@@ -193,7 +193,7 @@ jobs:
     - name: 🎯 Run Complete Test Suite
       run: |
         echo "🎯 Running Comprehensive Test Suite..."
-        go run scripts/test_runner.go
+        go run test_runner.go
 
   # ==================================================
   # 🏗️ Build & Release Artifacts

app/app_test.go

@@ -108,7 +108,7 @@ os.Setenv("HOME", tempDir)
 // Change to temp directory
 originalWd, err := os.Getwd()
 require.NoError(t, err)
-defer func() { os.Chdir(originalWd) }()
+defer func() { _ = os.Chdir(originalWd) }()
 
 workDir := filepath.Join(tempDir, "project")
 err = os.MkdirAll(workDir, 0755)
@@ -201,6 +201,6 @@ b.ResetTimer()
 for i := 0; i < b.N; i++ {
 // Use different directory for each iteration
 testDir := fmt.Sprintf("/bench/dir/%d", i)
-app.AddTrustedDir(testDir)
+_ = app.AddTrustedDir(testDir)
 }
 }

app/root.go

@@ -38,7 +38,7 @@ func (m RootModel) handleScreenChange(msg models.ScreenChangeMsg) (RootModel, te
 switch msg.NewScreen {
 case models.Welcome:
 if data, ok := msg.Data.(string); ok {
-m.app.AddTrustedDir(data)
+_ = m.app.AddTrustedDir(data)
 m.currentModel = ui.NewWelcomeModel(data)
 }
 

config/config_test.go

@@ -311,6 +311,6 @@ func BenchmarkConfig_Validate(b *testing.B) {
 
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
-		config.Validate()
+		_ = config.Validate()
 	}
 }

e2e/aura_test.go

@@ -329,7 +329,7 @@ os.Setenv("HOME", tempDir)
 // Change to temp directory
 originalWd, err := os.Getwd()
 require.NoError(t, err)
-t.Cleanup(func() { os.Chdir(originalWd) })
+t.Cleanup(func() { _ = os.Chdir(originalWd) })
 
 err = os.Chdir(tempDir)
 require.NoError(t, err)
@@ -366,8 +366,8 @@ defer func() { os.Setenv("HOME", oldHome) }()
 os.Setenv("HOME", tempDir)
 
 originalWd, _ := os.Getwd()
-defer os.Chdir(originalWd)
-os.Chdir(tempDir)
+defer func() { _ = os.Chdir(originalWd) }()
+_ = os.Chdir(tempDir)
 
 // Create test config
 cfg := &config.Config{

llm/client.go

@@ -195,14 +195,14 @@ return "", fmt.Errorf("no content in response")
 return anthropicResp.Content[0].Text, nil
 }
 
-func (c *Client) chatGemini(messages []Message) (string, error) {
+func (c *Client) chatGemini(_ []Message) (string, error) {
 // Placeholder for Gemini implementation
-return "", fmt.Errorf("Gemini integration coming soon! Please use OpenAI or Anthropic for now.")
+return "", fmt.Errorf("gemini integration coming soon! Please use OpenAI or Anthropic for now")
 }
 
-func (c *Client) chatCohere(messages []Message) (string, error) {
+func (c *Client) chatCohere(_ []Message) (string, error) {
 // Placeholder for Cohere implementation
-return "", fmt.Errorf("Cohere integration coming soon! Please use OpenAI or Anthropic for now.")
+return "", fmt.Errorf("cohere integration coming soon! Please use OpenAI or Anthropic for now")
 }
 
 // Helper function to create a coding assistant system prompt

llm/client_api_test.go

@@ -64,7 +64,7 @@ func TestClient_ChatOpenAI_Success(t *testing.T) {
 		}
 
 		w.Header().Set("Content-Type", "application/json")
-		json.NewEncoder(w).Encode(response)
+		_ = json.NewEncoder(w).Encode(response)
 	}))
 	defer server.Close()
 
@@ -120,7 +120,7 @@ func TestClient_ChatAnthropic_Success(t *testing.T) {
 		}
 
 		w.Header().Set("Content-Type", "application/json")
-		json.NewEncoder(w).Encode(response)
+		_ = json.NewEncoder(w).Encode(response)
 	}))
 	defer server.Close()
 
@@ -143,9 +143,9 @@ func TestClient_ChatAnthropic_Success(t *testing.T) {
 
 func TestClient_ChatOpenAI_APIError(t *testing.T) {
 	// Create mock server that returns an error
-	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 		w.WriteHeader(http.StatusUnauthorized)
-		w.Write([]byte(`{"error": {"message": "Invalid API key"}}`))
+		_, _ = w.Write([]byte(`{"error": {"message": "Invalid API key"}}`))
 	}))
 	defer server.Close()
 
@@ -202,7 +202,7 @@ func TestClient_ChatOpenAI_EmptyResponse(t *testing.T) {
 		}
 
 		w.Header().Set("Content-Type", "application/json")
-		json.NewEncoder(w).Encode(response)
+		_ = json.NewEncoder(w).Encode(response)
 	}))
 	defer server.Close()
 

models/models_test.go

@@ -266,7 +266,7 @@ assert.Equal(t, tt.wantMsg, msg)
 }
 
 func TestConfirmationMsg(t *testing.T) {
-testCallback := func(confirmed bool) tea.Cmd {
+testCallback := func(_ bool) tea.Cmd {
 return func() tea.Msg {
 return StatusMsg{Message: "callback executed"}
 }

scripts/test_runner.go

@@ -71,9 +71,8 @@ fmt.Printf("Total: %d tests, %d passed, %d failed\n", totalTests, totalPassed, t
 if totalFailed > 0 {
 fmt.Printf("\n❌ Some tests failed. See output above for details.\n")
 os.Exit(1)
-} else {
-fmt.Printf("\n✅ All tests passed! 🎉\n")
 }
+fmt.Printf("\n✅ All tests passed! 🎉\n")
 }
 
 type TestResult struct {

ui/config.go

@@ -262,7 +262,7 @@ return m, nil
 }
 
 m.showSuccess = true
-return m, tea.Tick(time.Second*2, func(t time.Time) tea.Msg {
+return m, tea.Tick(time.Second*2, func(_ time.Time) tea.Msg {
 return models.ScreenChangeMsg{
 NewScreen: models.Welcome,
 Data:      m.currentDir,