Skip to content

Commit 7a8d1eb

Browse files
committed
Unlocked public filters logged-in user created
1 parent 7945224 commit 7a8d1eb

File tree

2 files changed

+22
-13
lines changed

2 files changed

+22
-13
lines changed

src/Resources/views/admin/reports/layout.html.twig

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,16 +28,22 @@
2828
{% endif %}
2929

3030
{# main filter #}
31-
{% set publicFilters = [
32-
{
33-
id: 'all',
34-
name: 'All Records',
35-
params: defaultFilter,
36-
isLocked: true,
37-
isDefault: true
38-
}
39-
] %}
40-
{{ UI.filterDropdown(sectionFilter, publicFilters, filters, app.request.get('filters'), defaultFilterUrl|default(null), editFilterUrl|default(null), deleteFilterUrl|default(null)) }}
31+
{% if publicFilters is not defined %}
32+
{% set publicFilters = [
33+
{
34+
id: 'all',
35+
name: 'All Records',
36+
params: defaultFilter,
37+
isDefault: true
38+
}
39+
] %}
40+
{% endif %}
41+
42+
{% if privateFilters is not defined %}
43+
{% set privateFilters = filters %}
44+
{% endif %}
45+
46+
{{ UI.filterDropdown(sectionFilter, publicFilters, privateFilters, app.request.get('filters'), defaultFilterUrl|default(null), editFilterUrl|default(null), deleteFilterUrl|default(null)) }}
4147
</div>
4248

4349
{# tools/actions #}

src/Resources/views/macros.html.twig

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -573,6 +573,7 @@
573573
{% for filter in publicFilters %}
574574
{% if defaultFilterId == filter.id %}
575575
{% set defaultFilter = filter %}
576+
{% set defaultIsLocked = app.user.id != filter.user|default({id: null}).id %}
576577
{% endif %}
577578
{% endfor %}
578579
{% if privateFilters is iterable %}
@@ -589,6 +590,7 @@
589590
{% if filter.isDefault|default(false) %}
590591
{% set defaultFilterId = filter.id %}
591592
{% set defaultFilter = filter %}
593+
{% set defaultIsLocked = app.user.id != filter.user|default({id: null}).id %}
592594
{% endif %}
593595
{% endfor %}
594596
{% endif %}
@@ -603,6 +605,7 @@
603605
{% for filter in publicFilters %}
604606
{% if not defaultFilter and preloadFilters == filter.params|default({})|filter_json_encode %}
605607
{% set defaultFilter = filter %}
608+
{% set defaultIsLocked = app.user.id != filter.user|default({id: null}).id %}
606609
{% endif %}
607610
{% endfor %}
608611
{% if privateFilters is iterable %}
@@ -687,11 +690,11 @@
687690
filter.name|title,
688691
filter.params|default({}),
689692
false,
690-
true,
693+
app.user.id != filter.user|default({id: null}).id,
691694
defaultFilterId == filter.id,
692695
defaultUrl,
693-
null,
694-
null,
696+
editUrl,
697+
deleteUrl,
695698
filter.isDefault|default(false)
696699
) }}
697700
{% endfor %}

0 commit comments

Comments
 (0)