Skip to content

Commit 1aad38b

Browse files
committed
Never add @returnvalue annotation for void methods
Fixes kohsuke#72
1 parent 1e690b8 commit 1aad38b

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

tlbimp/src/main/java/com4j/tlbimp/MethodBinder.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -547,9 +547,10 @@ protected final void declareReturnType(IndentingWriter o, List<IType> intermedia
547547
TypeBinding retBinding = TypeBinding.bind(g, returnType, null);
548548

549549
// add @ReturnValue if necessary
550-
if ((!retBinding.isDefault && needsMarshalAs()) || (retParam != -1 && (params[retParam].isIn() || retParam != params.length - 1))
551-
|| intermediates != null
552-
|| usesDefaltValues) {
550+
if (((!retBinding.isDefault && needsMarshalAs()) || (retParam != -1 && (params[retParam].isIn() || retParam != params.length - 1))
551+
|| intermediates != null
552+
|| usesDefaltValues)
553+
&& !retBinding.javaType.equals("void")) {
553554
o.print("@ReturnValue(");
554555
o.beginCommaMode();
555556
if (!retBinding.isDefault && needsMarshalAs()) {

0 commit comments

Comments
 (0)