Fixing caches of Binary Option Markets (Synthetixio#1146)

Author: justin j. moses

publish/src/commands/deploy.js

@@ -1218,7 +1218,7 @@ const deploy = async ({
 	const poolFee = w3utils.toWei('0.008'); // 0.8% of the market's value goes to the pool in the end.
 	const creatorFee = w3utils.toWei('0.002'); // 0.2% of the market's value goes to the creator.
 	const refundFee = w3utils.toWei('0.05'); // 5% of a bid stays in the pot if it is refunded.
-	await deployer.deployContract({
+	const binaryOptionMarketManager = await deployer.deployContract({
 		name: 'BinaryOptionMarketManager',
 		args: [
 			account,
@@ -1567,6 +1567,131 @@ const deploy = async ({
 		}
 	}
 
+	// Now do binary option market cache rebuilding
+	if (binaryOptionMarketManager) {
+		console.log(gray('Checking all binary option markets have rebuilt caches'));
+		let binaryOptionMarkets = [];
+		// now grab all possible binary option markets to rebuild caches as well
+		const binaryOptionsFetchPageSize = 100;
+		for (const marketType of ['Active', 'Matured']) {
+			const numBinaryOptionMarkets = Number(
+				await binaryOptionMarketManager.methods[`num${marketType}Markets`]().call()
+			);
+			console.log(
+				gray('Found'),
+				yellow(numBinaryOptionMarkets),
+				gray(marketType, 'binary option markets')
+			);
+
+			if (numBinaryOptionMarkets > binaryOptionsFetchPageSize) {
+				console.log(
+					redBright(
+						'⚠⚠⚠ Warning: cannot fetch all',
+						marketType,
+						'binary option markets as there are',
+						numBinaryOptionMarkets,
+						'which is more than page size of',
+						binaryOptionsFetchPageSize
+					)
+				);
+			} else {
+				// fetch the list of markets
+				const marketAddresses = await binaryOptionMarketManager.methods[
+					`${marketType.toLowerCase()}Markets`
+				](0, binaryOptionsFetchPageSize).call();
+
+				// wrap them in a contract via the deployer
+				const markets = marketAddresses.map(
+					binaryOptionMarket =>
+						new deployer.web3.eth.Contract(compiled['BinaryOptionMarket'].abi, binaryOptionMarket)
+				);
+
+				binaryOptionMarkets = binaryOptionMarkets.concat(markets);
+			}
+		}
+
+		// now figure out which binary option markets need their caches rebuilt
+		const binaryOptionMarketsToRebuildCacheOn = [];
+		for (const market of binaryOptionMarkets) {
+			try {
+				const isCached = await market.methods.isResolverCached().call();
+				if (!isCached) {
+					binaryOptionMarketsToRebuildCacheOn.push(addressOf(market));
+				}
+				console.log(
+					gray('Binary option market'),
+					yellow(addressOf(market)),
+					gray('is newer and cache status'),
+					yellow(isCached)
+				);
+			} catch (err) {
+				// the challenge being that some used an older MixinResolver API
+				const oldBinaryOptionMarketABI = [
+					{
+						constant: true,
+						inputs: [
+							{
+								internalType: 'contract AddressResolver',
+								name: '_resolver',
+								type: 'address',
+							},
+						],
+						name: 'isResolverCached',
+						outputs: [
+							{
+								internalType: 'bool',
+								name: '',
+								type: 'bool',
+							},
+						],
+						payable: false,
+						stateMutability: 'view',
+						type: 'function',
+						signature: '0x631e1444',
+					},
+				];
+
+				const oldBinaryOptionMarket = new deployer.web3.eth.Contract(
+					oldBinaryOptionMarketABI,
+					addressOf(market)
+				);
+
+				const isCached = await oldBinaryOptionMarket.methods
+					.isResolverCached(addressOf(readProxyForResolver))
+					.call();
+				if (!isCached) {
+					binaryOptionMarketsToRebuildCacheOn.push(addressOf(market));
+				}
+
+				console.log(
+					gray('Binary option market'),
+					yellow(addressOf(market)),
+					gray('is older and cache status'),
+					yellow(isCached)
+				);
+			}
+		}
+
+		console.log(
+			gray('In total'),
+			yellow(binaryOptionMarketsToRebuildCacheOn.length),
+			gray('binary option markets need their caches rebuilt')
+		);
+
+		const addressesChunkSize = useOvm ? 7 : 20;
+		for (let i = 0; i < binaryOptionMarketsToRebuildCacheOn.length; i += addressesChunkSize) {
+			const chunk = binaryOptionMarketsToRebuildCacheOn.slice(i, i + addressesChunkSize);
+			await runStep({
+				gasLimit: useOvm ? OVM_MAX_GAS_LIMIT : 7e6,
+				contract: `BinaryOptionMarketManager`,
+				target: binaryOptionMarketManager,
+				publiclyCallable: true, // does not require owner
+				write: 'rebuildMarketCaches',
+				writeArg: [chunk],
+			});
+		}
+	}
+
 	// Now perform a sync of legacy contracts that have not been replaced in Shaula (v2.35.x)
 	// EtherCollateral, EtherCollateralsUSD
 	console.log(gray('Checking all legacy contracts with setResolverAndSyncCache() are rebuilt...'));