#55 Fixed the empty input bug #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckunki
previously approved these changes
Oct 22, 2024
| _ = StandaloneMockContext(inp, meta_data) | ||
| # There is nothing to test here apart from successful creation of the | ||
| # context object. This internally has some checks that need to be passed. | ||
| pass |
There was a problem hiding this comment.
Maybe the test could assert that the constructor does not raise an exception?
https://stackoverflow.com/questions/4319825/python-unittest-opposite-of-assertraises
There was a problem hiding this comment.
I don't understand why it is so important to make a distinction between a failure and an error. Either way, pytest will point out where the problem is. If you convert an exception to an assert failure you are more likely to hide the actual cause of the error.
There was a problem hiding this comment.
Maybe you can enlighten me.
Co-authored-by: Christoph Kuhnke <christoph.kuhnke@exasol.com>
ckunki
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #55
closes #56
All Submissions: