Refactoring/260 added unit tests for cli param wrappers #261
Conversation
ckunki
had a problem deploying
to
manual-approval
GitHub Actions
Failure
ckunki
had a problem deploying
to
manual-approval
GitHub Actions
Failure
| metavar="DB_SCHEMA", | ||
| type=str, | ||
| help="Database schema for installing UDFs of Exasol extensions", | ||
| scs_key=CKey.db_schema, |
There was a problem hiding this comment.
This had been forgotten in the last PR
ckunki
had a problem deploying
to
manual-approval
GitHub Actions
Failure
ckunki
had a problem deploying
to
manual-approval
GitHub Actions
Failure
|
|
||
| @property | ||
| def arg_name(self) -> str: | ||
| return self._args[0] |
There was a problem hiding this comment.
what if *args is empty?
Default value here, like ""?
There was a problem hiding this comment.
Or maybe check in constructor already that *args is not empty....
There was a problem hiding this comment.
I was lazy. You are right.
See next push adding a fix.
There was a problem hiding this comment.
Thanks.
Annoying but excellent finding.
See latest push addressing your findings.
| envvar="KWARG_ENVVAR", | ||
| metavar="NAME", | ||
| type=str, | ||
| default="Robert", |
There was a problem hiding this comment.
Sorry I know some Badesalz but "Robert" was unknown to me. 🙂
I just picked a random name.
ckunki
had a problem deploying
to
manual-approval
GitHub Actions
Failure
ckunki
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
| Represents a CLI argument for the SCS command. | ||
| """ | ||
|
|
||
| def __init__(self, name: str, scs_key: CKey | None = None, **kwargs): |
ckunki
temporarily deployed
to
text-ai-prerelease
GitHub Actions
Inactive
|
ckunki
deleted the
refactoring/260-Added_unit_tests_for_CLI_param_wrappers
branch
Closes #260