Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test covering RichContext parent inheritance. #127

Closed
dwreeves opened this issue Oct 7, 2023 · 1 comment
Closed

Unit test covering RichContext parent inheritance. #127

dwreeves opened this issue Oct 7, 2023 · 1 comment
Labels
good first issue Good for newcomers testing Related to testing, coverage, linting, etc.

Comments

@dwreeves
Copy link
Collaborator

dwreeves commented Oct 7, 2023

rich_config inside of RichGroups should pass to objects created by RichGroup.command and RichGroup.group, when said objects do not have their own rich_config. This is done via the RichContext inheriting attributes from the parent context.

This behavior is currently working in the latest dev version, but it is not enforced in tests and it should be.
@dwreeves dwreeves added the good first issue Good for newcomers label Oct 7, 2023
@dwreeves dwreeves mentioned this issue Oct 7, 2023
Merged
@dwreeves dwreeves added the testing Related to testing, coverage, linting, etc. label Oct 8, 2023
@dwreeves
Copy link
Collaborator Author

I do believe this is being tested now. Or maybe I meant something else when I typed this out way back when. Who knows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers testing Related to testing, coverage, linting, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dwreeves