Skip to content
This repository has been archived by the owner on Jan 5, 2019. It is now read-only.

Fix CALL* to actually support the return area #273

Open
axic opened this issue May 29, 2018 · 0 comments
Open

Fix CALL* to actually support the return area #273

axic opened this issue May 29, 2018 · 0 comments

Comments

@axic
Copy link
Member

axic commented May 29, 2018

Currently CALL* just drops the last two parametes which specify the output area and length.

Tests should expect data to be written there so I'd think at some point tests going to fail. The better way to deal with this is to insert a helper which uses returndatacopy to write the result into the destination spcified. The one thing to take attention to is that returndatacopy throws on overread, while old style call* doesn't.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant