move action to setChecked

Author: Eric Wang

MasterFramework Dev/Framework/Controls/CheckBox.lua

@@ -2,8 +2,7 @@ function framework:CheckBox(scale, defaultState, action)
     local checkbox
     local dimension = framework:AutoScalingDimension(scale)
     local radius = framework:AutoScalingDimension(scale / 2)
-
-    local checked = defaultState
+    local checked
 
     local highlightColor = framework.color.hoverColor
     local unhighlightedColor = framework.stroke.defaultBorder
@@ -24,7 +23,6 @@ function framework:CheckBox(scale, defaultState, action)
                 highlightColor = framework.color.hoverColor
                 if framework.PointIsInRect(x, y, self:Geometry()) then
                     checkbox:SetChecked(not checked)
-                    action(checkbox, checked)
                 end
             end
         ),
@@ -37,9 +35,9 @@ function framework:CheckBox(scale, defaultState, action)
         checked = newChecked
         unhighlightedColor = (checked and framework.color.selectedColor) or framework.stroke.defaultBorder
         rect:SetDecorations({ (isInside and highlightColor) or unhighlightedColor })
+        action(checkbox, checked)
     end
 
-    checkbox:SetChecked(checked)
-    action(checkbox, checked)
+    checkbox:SetChecked(defaultState)
     return checkbox
-end
+end