Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Join functions #7

Open
evinism opened this issue Sep 21, 2021 · 2 comments
Open

Join functions #7

evinism opened this issue Sep 21, 2021 · 2 comments

Comments

@evinism
Copy link
Owner

evinism commented Sep 21, 2021

Can imagine:

join.left
join.right
join.outer
join.inner
@cfilipov
Copy link

cfilipov commented Nov 1, 2021

You have a join function which is used for concatenating strings with a separator which I feel can be confusing with the relational joins proposed. Maybe the existing join should be concat or something?

@evinism
Copy link
Owner Author

evinism commented Nov 1, 2021

yeah, that naming conflict has definitely been a concern of mine for a bit -- i opted for join as the inverse of split, but that might have been a poor long-term choice. I like concat though!

I also think now is the right time to correct this -- if i don't it's going to be very annoying to correct in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evinism @cfilipov