This repository was archived by the owner on Apr 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature: Support multiple actions #20
Open
r17x
wants to merge
6
commits into
next
Choose a base branch
from
feature/support-multiple-actions-init
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why should we use this approach? |
Can you please elaborate more related with this changes? For what I understand, this approach is to reducing ceremony in dispatching some action. So, this action payload: {
type: 'LOGIN',
payload: {
username: 'fariz',
password: 's3ndnud3s'
}
} Is simplified (or replaced with) to this: action.login({
payload: {
username: 'fariz',
password: 's3ndnud3s'
}
}) Or even this: action.login({
username: 'fariz',
password: 's3ndnud3s'
}) Let me know if I'm wrong |
Btw my comment was based on this test file. const ChangeTest = () => {
- const [, dispatch] = useGlobalState()
+ const [, actions] = useGlobalState()
...
- dispatch({
+ actions.changeTest({
type: 'TEST'
})
|
Closed by accident, sorry |
I think we can close this project cause in react have so many alternative and we not maintain this project, wdyt ? @faultable |
do your best, bro |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this change?
when init provider can be includes with actions and use like this
actions.changeMe
https://github.com/evilfactorylabs/useGlobalState/pull/20/files#diff-04c6e90faac2675aa89e2176d2eec7d8R118