Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching for the United States #2

Open
shaun-yb opened this issue Mar 22, 2020 · 0 comments
Open

Searching for the United States #2

shaun-yb opened this issue Mar 22, 2020 · 0 comments

Comments

@shaun-yb
Copy link
Contributor

There is a bug when you are trying to search for the United States. This is caused by two things:

  1. The dataset only contains the key US. When the API gets a country string, it looks up that country name in the JSON hash provided by HTTParty. This is why it fails on terms like United States, USA, etc.

  2. The capitalize method here is changing US to Us. There is no Us key in the hash so we will not be able to find it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shaun-yb