Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to update test fixtures #15607

Open
chrismytton opened this issue Feb 17, 2017 · 0 comments · May be fixed by #15610
Open

Make it easier to update test fixtures #15607

chrismytton opened this issue Feb 17, 2017 · 0 comments · May be fixed by #15610
Labels

Comments

@chrismytton
Copy link
Contributor

Problem

At the moment updating the test fixtures involves lots of bitty steps that are easy to get wrong. This means that the tests run against quite an old version of everypolitician-data. It would be good to make this easier so we can test the app against newer versions of the data.

Proposed Solution

Add a rake task which updates t/fixtures/countries.json (which is currently called d8a4682f-countries.json) and the files in t/fixtures/everypolitician-data to the latest version on the everypolitician-data master branch.

This will involve going through the output from git grep stub_ t/ and removing any hard-coded SHAs and moving those into a single central data file. This way the SHAs are tracked under source control but don't need to be updated in the individual tests each time.

Acceptance Criteria

Updating the test fixtures to the latest version should only require one command.

Related Issues

This is needed in order to do #15606 because the current version of the fixtures don't have the type column in the unstable/positions.csv, so it's awkward to add a test for the Position#type method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant