Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch release.sh to use Travis deploy scripts #15554

Open
chrismytton opened this issue Sep 20, 2016 · 0 comments
Open

Switch release.sh to use Travis deploy scripts #15554

chrismytton opened this issue Sep 20, 2016 · 0 comments

Comments

@chrismytton
Copy link
Contributor

Problem

We're currently doing the deploy as part of the build process on Travis, which means the release.sh script has to know more than necessary about the Travis environment.

Proposed Solution

We should use Travis' script deployment mechanism like we've already done in everypolitician/everypolitician-data@16f213b to deploy the site when the master branch is successfully built. Note that we still want to execute the build part of release.sh when we're running the tests for a pull request, since that will tell us if there are any problems building the static site from the new code in the pull request. So we might need to either add a flag to release.sh or possibly split it into a build.sh and a deploy.sh script for the different steps.

Acceptance Criteria

There shouldn't be any dependency on TRAVIS_* environment variables in the release.sh (or equivalent) scripts.

Not Required

We don't need to change anything about the way the site is deployed, we just need to move it to a different part of the Travis build.

Prerequisites

None.

Related Issues

Due Date

None.

Design?

No.

Text?

No.

Bloggable?

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants