You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should use Travis' script deployment mechanism like we've already done in everypolitician/everypolitician-data@16f213b to deploy the site when the master branch is successfully built. Note that we still want to execute the build part of release.sh when we're running the tests for a pull request, since that will tell us if there are any problems building the static site from the new code in the pull request. So we might need to either add a flag to release.sh or possibly split it into a build.sh and a deploy.sh script for the different steps.
Acceptance Criteria
There shouldn't be any dependency on TRAVIS_* environment variables in the release.sh (or equivalent) scripts.
Not Required
We don't need to change anything about the way the site is deployed, we just need to move it to a different part of the Travis build.
Problem
We're currently doing the deploy as part of the build process on Travis, which means the
release.sh
script has to know more than necessary about the Travis environment.Proposed Solution
We should use Travis' script deployment mechanism like we've already done in everypolitician/everypolitician-data@16f213b to deploy the site when the
master
branch is successfully built. Note that we still want to execute the build part ofrelease.sh
when we're running the tests for a pull request, since that will tell us if there are any problems building the static site from the new code in the pull request. So we might need to either add a flag torelease.sh
or possibly split it into abuild.sh
and adeploy.sh
script for the different steps.Acceptance Criteria
There shouldn't be any dependency on
TRAVIS_*
environment variables in therelease.sh
(or equivalent) scripts.Not Required
We don't need to change anything about the way the site is deployed, we just need to move it to a different part of the Travis build.
Prerequisites
None.
Related Issues
Due Date
None.
Design?
No.
Text?
No.
Bloggable?
No.
The text was updated successfully, but these errors were encountered: