Skip to content

Conversation

@DAnn2012
Copy link

Problem this Pull Request solves

Fixed Function in messages_settings.help_tab.php

How has this been tested

Checklist

@garthkoyle garthkoyle requested a review from tn3rb September 24, 2025 15:17
Copy link
Member

@tn3rb tn3rb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@tn3rb
Copy link
Member

tn3rb commented Oct 6, 2025

@DAnn2012

Thanks for your contribution, your change looks great.

All of our development happens on a giant private monorepo that includes the code for ALL of our plugins (~80 plugins) and we only publish releases on each plugin's individual public repo like this one.

Your pull request can't simply be merged as the change would not make it into our main codebase and would get overwritten as soon as the next release is published here.
So instead I'm going to generate a patch from your commit and import that into the monorepo so that you can receive the attribution and have the commit appear on your profile.

However, if that doesn't work for some reason, I may have to manually copy your change over and then use your name and GitHub email address when making the commit. GitHub doesn't publicly display a user's email addresses on their profile, so I can try to extract your GitHub email address from the git log, but if I can't do that, I will comment here again and then you can email me at brent@eventespresso.com with the email address you use on your GitHub profile (even if it's a no‑reply address) because that has to match your profile if you want to receive credit for your commit.

Assuming one of the above paths works, it could still take a while before the commit makes it into a release here. You can make this change in your local code, but it could get overwritten if the next release here does not include that patch yet. Eventually it will get here though. My apologies for any inconveniences that may cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants