Merge pull request #2 from event-engine/feature/allow_index_arg_on_drop_index

Alexander Miertsch · web-flow · commit 4012a25b4070 · 2019-07-06T21:56:40.000+02:00
Allow passing Index arg to dropIndex
diff --git a/src/DocumentStore.php b/src/DocumentStore.php
@@ -59,10 +59,10 @@ public function addCollectionIndex(string $collectionName, Index $index): void;
 
     /**
      * @param string $collectionName
-     * @param string $indexName
+     * @param string|Index $index
      * @throws RuntimeException if dropping did not succeed
      */
-    public function dropCollectionIndex(string $collectionName, string $indexName): void;
+    public function dropCollectionIndex(string $collectionName, $index): void;
 
     /**
      * @param string $collectionName
diff --git a/src/InMemoryDocumentStore.php b/src/InMemoryDocumentStore.php
@@ -99,10 +99,10 @@ public function addCollectionIndex(string $collectionName, Index $index): void
 
     /**
      * @param string $collectionName
-     * @param string $indexName
+     * @param string|Index $index
      * @throws RuntimeException if dropping did not succeed
      */
-    public function dropCollectionIndex(string $collectionName, string $indexName): void
+    public function dropCollectionIndex(string $collectionName, $index): void
     {
         //InMemoryDocumentStore ignores indices
     }

Original file line number	Diff line number	Diff line change
`@@ -99,10 +99,10 @@ public function addCollectionIndex(string $collectionName, Index $index): void`
`99`	`99`
`100`	`100`	`/**`
`101`	`101`	`* @param string $collectionName`
`102`		`- * @param string $indexName`
	`102`	`+ * @param string\|Index $index`
`103`	`103`	`* @throws RuntimeException if dropping did not succeed`
`104`	`104`	`*/`
`105`		`- public function dropCollectionIndex(string $collectionName, string $indexName): void`
	`105`	`+ public function dropCollectionIndex(string $collectionName, $index): void`
`106`	`106`	`{`
`107`	`107`	`//InMemoryDocumentStore ignores indices`
`108`	`108`	`}`