Updating docker files to support Inivation's DVXplorer Micro camera #17
Conversation
There was a problem hiding this comment.
Thank you for the suggestion.
If you add a support for Inivation's DVXploere Micro camera, we should create another Dockerfile only for this camera to simplify docker environments.
In addition, you added some changes for WSL system, which contaminate the environment. Important thing to manage Github repository is to simplify the environment. So, I recommend you to revert these modifications.
| ENV LD_LIBRARY_PATH=/usr/lib/wsl/lib | ||
| ENV LIBVA_DRIVER_NAME=d3d12 |
There was a problem hiding this comment.
This part is for WSL system.
In my opinion, we don't need to prepare a docker environment for WSL users to simplify this repository.
Therefore, could you please delete this part to focus on Linux environments?
| # dv-processing | ||
| # Add toolchain PPA and install gcc-13/g++-13 | ||
| RUN apt update && \ | ||
| apt install -y software-properties-common && \ | ||
| add-apt-repository ppa:ubuntu-toolchain-r/test && \ | ||
| apt update && \ | ||
| apt install -y gcc-13 g++-13 | ||
|
|
||
| # Add inivation PPA and install dv-processing dependencies | ||
| RUN add-apt-repository ppa:inivation-ppa/inivation && \ | ||
| apt-get update && \ | ||
| apt-get install -y \ | ||
| boost-inivation \ | ||
| libcaer-dev \ | ||
| libfmt-dev \ | ||
| liblz4-dev \ | ||
| libzstd-dev \ | ||
| libssl-dev && \ | ||
| apt-get -y install dv-processing | ||
|
|
||
| ENV CC=gcc-13 | ||
| ENV CXX=g++-13 | ||
| ENV BOOST_ROOT=/opt/inivation/boost | ||
| ENV BOOST_INCLUDEDIR=/opt/inivation/boost/include | ||
| ENV BOOST_LIBRARYDIR=/opt/inivation/boost/lib | ||
|
|
There was a problem hiding this comment.
As I recommended you in event-driven repository Link, I can also recommend you to create some Dockerfiles to simplify environments.
Therefore, could you make them in the following folder structure?
EDOPT/
├── docker/
│ ├── Prophesee/
│ └── Dockerfile
│ ├── Inivation/
│ └── Dockerfile
| @@ -1,19 +1,24 @@ | |||
| services: | |||
| edopt: | |||
| testedopt: | |||
There was a problem hiding this comment.
We don't need to change service name.
| environment: | ||
| - DISPLAY=unix$DISPLAY | ||
| - /tmp/.X11-unix:/tmp/.X11-unix | ||
| - /usr/lib/wsl:/usr/lib/wsl |
There was a problem hiding this comment.
This part is also for WSL. Could you delete it not to contaminate the docker environment?
| devices: | ||
| - /dev/dxg:/dev/dxg |
There was a problem hiding this comment.
This part is also for WSL, so could you please delete it?
| stdin_open: true | ||
| tty: true |
There was a problem hiding this comment.
If you just want to go inside docker container, you just do docker exec -it edopt /bin/bash.
Therefore, this modification is not required.
So, could you revert this part?
2 participants
Updated versions of the docker and docker-compose file to allow interaction with
dv-bridge-sdkand use of GPU ressources. These are the modifications I used to develop and test thedv-bridge-sdk, as discussed with @arrenglover . Have a good day!