Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrapped into library #7

Merged
merged 40 commits into from
Jun 20, 2024
Merged

wrapped into library #7

merged 40 commits into from
Jun 20, 2024

Conversation

lsfera
Copy link
Contributor

@lsfera lsfera commented May 9, 2024

Split pub sub
tests on compose
Wrapped subscriptionoptions to expose via library

@lsfera
quick demo
004472e
@lsfera
added pgadmin
ba40624
@lsfera
removed some code
f44ed97
@lsfera
simplify logic
4f17e4a
@lsfera
fix typos
71cf25d
@lsfera
todo: execute tests against containers - https://dotnet.testcontainer…
d05cdfd 
…s.org/
@lsfera
limit to insert only record
27c38e6
@lsfera
testing within docker
a2803a2
@lsfera
Enable AOT
850790e
@lsfera
add sample of benchmarking technique
a59deae
@lsfera
remove version
efd6a64
@lsfera
simplify serialization config
df89bcf
@lsfera
more ergonomic approach to configuration
4dd31f5
@lsfera
expose naming policy to configure how type is serialized ( default is…
8a1ab2a 
… FQN)
@lsfera
just some cleanup
92f1843
@lsfera
review type resolver
f236f7b
@lsfera
continue on simplifycatiion
c15a43d
@lsfera
ensure outbox table exists when subscribing
e9ff768 
declare id as bigint
@lsfera
prepare for prerelease
b601bd5
@lsfera
subscribe exposes generic return type
39a6ac7
@lsfera
move source code in 'src' folder
51c1571
@lsfera
update deps
3a7315e
@lsfera
AOT enforced on subsriber
1b2b400
@lsfera
add AttributeNamingPolicy for maximum flexibility
aca0e10
@lsfera
split commons into pub sub demo project to better illustrate design c…
493019b 
…apabilities
@lsfera
expose transfer mode option to enable binary format - https://www.pos…
4822e6f 
…tgresql.org/docs/current/protocol-logical-replication.html - but defaulting to text
@lsfera
Expose npgsql driver logging
ea743d0
@lsfera
some methods rename
06a6118
@lsfera
Ensure table exists before creating logical replication
176ac51
@lsfera
testing all positive scenario
9d9ffd0
oskardudycz
oskardudycz reviewed Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@oskardudycz oskardudycz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added smaller comments and suggestions, but in overall that looks great. Such PRs make me love OSS again 😅

Could you also check the docker-compose config as the pipeline is failing?

@oskardudycz
Copy link
Collaborator

@lsfera, thank you a lot for your hard work on that; I'm merging it as it is and creating the dedicated issues based on our conversations.

I'll probably go ahead and prepare the package to be released. My code name is Benjamin Blümchen 😅

I'll also probably transfer the repository to the event-driven.io organisation for better housekeeping.

@oskardudycz oskardudycz merged commit 3d42e35 into event-driven-io:master Jun 20, 2024
1 check passed
This was referenced Jun 20, 2024
Open
Open
Closed
Open
Closed
Open
Open
Open
Open
Open
@oskardudycz
Copy link
Collaborator

@lsfera now it's here, if you're looking for it https://github.com/event-driven-io/Blumchen (just housekeeping, no changes to licensing etc.).

@oskardudycz
Copy link
Collaborator

@lsfera and here it is version 0.0.1 https://www.nuget.org/packages/Blumchen/ 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskardudycz oskardudycz oskardudycz left review comments

@dariogriffo dariogriffo dariogriffo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsfera @oskardudycz @dariogriffo