-
-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add carbonintensity.org.uk (National Grid ESO) CO2 forecasting #9387
Conversation
Wow, timestamps without seconds. Guess they really saved a few nibbles here and there. I feel your pain .... ;) |
@duckfullstop do you want to finish this? |
Apologies for the delay, been dealing with personal life stuff 😞 I'll try my best to spend a little more time this week refactoring it, but if I'm not able to carve some time out before the weekend it'll probably be best for me to drop it and either let someone else take it on, or stick it on my backburner. |
This supports the National Grid Electricity System Operator's carbonintensity service, supplying information on forecast CO2 per kWh.
9e0becd
to
d099c0c
Compare
Really nice pr. Only left a few nitpicks, certainly more personal preference than solid Go. Thank you! |
I think 5d5756d fixes your comments, mind taking another quick look? |
I'll get that batch of changes implemented later today 🤞 |
Co-authored-by: andig <cpuidle@gmx.de>
oops, my IDE gets too excited sometimes
Whoops, github got a bit too eager here
Per discussion in evcc-io#9387
One last thing ;). Do you want to add example config to evcc.dist.yaml? We do not document/configure tariffs yet :/ /cc @VolkerK62 |
Done in 8da9436 💙 We'll need some updated documentation too, I'll separately PR that in due time. |
Really great PR, much appreciated! |
There is also demand for EntsoE if you want to take a stab 😀 |
Could you raise an issue for it and tag me in it? (Unless there's already one ongoing somewhere) |
@duckfullstop Entso-E is done :) |
This supports the National Grid Electricity System Operator's carbonintensity.org.uk service, supplying information on forecast CO2 per kWh.
Extremely sloppy first commit, just wanted to get something out the door - tests and a bit more refinement to come.
(oh my goodness is their API a mess, what have I gotten myself into?)