Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add carbonintensity.org.uk (National Grid ESO) CO2 forecasting #9387

Merged
merged 10 commits into from
Aug 31, 2023

Conversation

duckfullstop
Copy link
Contributor

This supports the National Grid Electricity System Operator's carbonintensity.org.uk service, supplying information on forecast CO2 per kWh.

Extremely sloppy first commit, just wanted to get something out the door - tests and a bit more refinement to come.

(oh my goodness is their API a mess, what have I gotten myself into?)

@GrimmiMeloni
Copy link
Collaborator

Wow, timestamps without seconds. Guess they really saved a few nibbles here and there. I feel your pain .... ;)

@andig andig changed the title Support for carbonintensity.org.uk (National Grid ESO) CO2 forecasting Add carbonintensity.org.uk (National Grid ESO) CO2 forecasting Aug 15, 2023
@andig andig added the enhancement New feature or request label Aug 15, 2023
@andig
Copy link
Member

andig commented Aug 29, 2023

@duckfullstop do you want to finish this?

@duckfullstop
Copy link
Contributor Author

Apologies for the delay, been dealing with personal life stuff 😞

I'll try my best to spend a little more time this week refactoring it, but if I'm not able to carve some time out before the weekend it'll probably be best for me to drop it and either let someone else take it on, or stick it on my backburner.

This supports the National Grid Electricity System Operator's carbonintensity service, supplying information on forecast CO2 per kWh.
@duckfullstop duckfullstop marked this pull request as ready for review August 30, 2023 18:20
@duckfullstop duckfullstop requested a review from andig August 30, 2023 19:34
@andig
Copy link
Member

andig commented Aug 30, 2023

Really nice pr. Only left a few nitpicks, certainly more personal preference than solid Go. Thank you!

@duckfullstop
Copy link
Contributor Author

I think 5d5756d fixes your comments, mind taking another quick look?

@duckfullstop
Copy link
Contributor Author

I'll get that batch of changes implemented later today 🤞

duckfullstop and others added 4 commits August 31, 2023 14:38
Co-authored-by: andig <cpuidle@gmx.de>
oops, my IDE gets too excited sometimes
Whoops, github got a bit too eager here
@duckfullstop duckfullstop requested a review from andig August 31, 2023 16:26
@andig
Copy link
Member

andig commented Aug 31, 2023

One last thing ;). Do you want to add example config to evcc.dist.yaml? We do not document/configure tariffs yet :/

/cc @VolkerK62

@duckfullstop
Copy link
Contributor Author

Do you want to add example config to evcc.dist.yaml? We do not document/configure tariffs yet :/

Done in 8da9436 💙

We'll need some updated documentation too, I'll separately PR that in due time.

@andig andig merged commit 216dcba into evcc-io:master Aug 31, 2023
@andig
Copy link
Member

andig commented Aug 31, 2023

Really great PR, much appreciated!

@duckfullstop duckfullstop deleted the feature-ukng-eso-co2 branch August 31, 2023 19:11
@andig
Copy link
Member

andig commented Aug 31, 2023

There is also demand for EntsoE if you want to take a stab 😀

@duckfullstop
Copy link
Contributor Author

There is also demand for EntsoE if you want to take a stab 😀

Could you raise an issue for it and tag me in it? (Unless there's already one ongoing somewhere)

@andig
Copy link
Member

andig commented Oct 7, 2023

@duckfullstop Entso-E is done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants