Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Target Charge Plan Visualisation #5860

Merged
merged 40 commits into from
Jan 29, 2023
Merged

Add Target Charge Plan Visualisation #5860

merged 40 commits into from
Jan 29, 2023

Conversation

naltatis
Copy link
Member

@naltatis naltatis commented Jan 21, 2023

Introduces a new UI to give users an insights what the target charge algorithm is doing. I opted for a reduced and simple visualisation. Its quite easy to create information overflow here and display every but our algorithm produces 😆.

  • End/start of charging sessions are in hour granularity (not min/secs).
  • A legend for the y axis is omitted but you can mouseover or touch a slot to find out the exact price/co2 value.

I think these are reasonable tradeoffs that shouldn't affect day to day usage. But feel free do comment.

Bildschirm­foto 2023-01-21 um 10 12 21

plan.mp4

You can play around with the UI at https://demo-next.evcc.io/
Please use the second loadpoint with the Model 3 for testing. The demo config seems to have planning issues with the first loadpoint.

Todos:

  • proper translation
  • test visual edge cases (more histoire examples)
  • optimise scrolling (maybe autoscroll to active slots)
  • deal with tariffs that don't start/end on full hours => something for a separate PR
  • optimize for larger screens
  • fix ui unit tests in pipeline (dates)

Thanks @markusrem for the design sparring.

@naltatis naltatis marked this pull request as draft January 21, 2023 09:28
@RTTTC
Copy link
Contributor

RTTTC commented Jan 21, 2023

Very nicely thought out!! ❤️
I know it would not be consistent with EVCC theme, but would be so cool if on large screens there would be no need to scroll left-right, and UI would just show it all instead. 😎 (larger / wider pop up?)

@andig andig added the ux User experience/ interface label Jan 21, 2023
@naltatis
Copy link
Member Author

be so cool if on large screens there would be no need to scroll left-right, and UI would just show it all instead. 😎 (larger / wider pop up?)

@RTTTC Good idea. One reason why did not expand the modal is, that the chart is currently not shown if there's an error (e.g. target in the past). Then we show a modal with a lot of whitespace. But maybe we can always show the chart, even in error cases. I'll play with that.

@naltatis
Copy link
Member Author

@RTTTC a large screen view could look like this. 42 hour forecast, no scrolling.

Bildschirm­foto 2023-01-21 um 12 57 02

@RTTTC
Copy link
Contributor

RTTTC commented Jan 21, 2023

I would love this look! ❤️

@StevieC121176
Copy link

Gefällt mir auch sehr gut. Ich könnte mir dies Art Anzeige auch als Auswertung im Ladelog vorstellen

@DerAndereAndi
Copy link
Contributor

Does it need two buttons? Isn't always only one button clickable ?

@naltatis
Copy link
Member Author

Does it need two buttons? Isn't always only one button clickable ?

The left one is disabled if no target time exists. If you open the dialog with an existing time you can remove the target or set a new one. So both are needed.

@andig
Copy link
Member

andig commented Jan 21, 2023

Vielleicht wäre es noch nett, falls der Plan zu sofortigem Start führen würde, den aktuellen Timeslot nochmal in anderem Grün zu machen analog der Ladeanzeige? Ggf noch eine Miniaturansicht des aktuellen Planes irgendwo im Haupt-UI?

@naltatis
Copy link
Member Author

naltatis commented Jan 22, 2023

Die Idee einer Miniaturansicht, vielleicht beim Statustext, find ich spannend. Ich schau mal ob wir da was schlankes machen können:

Zielladen aktiv ▂▁▄▃▆▅▇▂▁  << plus Farbe

@andig
Copy link
Member

andig commented Jan 22, 2023

In der Planneransicht selbst wäre es- neben aktivem aktuellen Slot- vllt auch schön, zu signalisieren wo der Plan endet. Dann könnte man sich sparen, weiter nach rechts zu scrollen. Also z.B. alle Slots die zwischen Plan Start/Ende liegen in dunklerem Grau oder hellem Grün?

i18n/en.toml Outdated Show resolved Hide resolved
@andig
Copy link
Member

andig commented Jan 23, 2023

In der Planneransicht selbst wäre es- neben aktivem aktuellen Slot- vllt auch schön, zu signalisieren wo der Plan endet. Dann könnte man sich sparen, weiter nach rechts zu scrollen. Also z.B. alle Slots die zwischen Plan Start/Ende liegen in dunklerem Grau oder hellem Grün?

Das ist ja schon so :)

i18n/de.toml Outdated Show resolved Hide resolved
@andig
Copy link
Member

andig commented Jan 23, 2023

Die Idee einer Miniaturansicht, vielleicht beim Statustext, find ich spannend. Ich schau mal ob wir da was schlankes machen können:

Zielladen aktiv ▂▁▄▃▆▅▇▂▁  << plus Farbe

Nächste Iteration- erstmal rein damit?

@naltatis
Copy link
Member Author

Bildschirm­foto 2023-01-29 um 21 45 36

Bildschirm­foto 2023-01-29 um 21 46 17

@naltatis naltatis marked this pull request as ready for review January 29, 2023 20:46
@naltatis naltatis merged commit f568cb8 into master Jan 29, 2023
@naltatis naltatis deleted the plan-api-ui branch January 29, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux User experience/ interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants