-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Target Charge Plan Visualisation #5860
Conversation
This reverts commit 35d3956.
Very nicely thought out!! ❤️ |
@RTTTC Good idea. One reason why did not expand the modal is, that the chart is currently not shown if there's an error (e.g. target in the past). Then we show a modal with a lot of whitespace. But maybe we can always show the chart, even in error cases. I'll play with that. |
@RTTTC a large screen view could look like this. 42 hour forecast, no scrolling. |
I would love this look! ❤️ |
Gefällt mir auch sehr gut. Ich könnte mir dies Art Anzeige auch als Auswertung im Ladelog vorstellen |
Does it need two buttons? Isn't always only one button clickable ? |
The left one is disabled if no target time exists. If you open the dialog with an existing time you can remove the target or set a new one. So both are needed. |
Vielleicht wäre es noch nett, falls der Plan zu sofortigem Start führen würde, den aktuellen Timeslot nochmal in anderem Grün zu machen analog der Ladeanzeige? Ggf noch eine Miniaturansicht des aktuellen Planes irgendwo im Haupt-UI? |
Die Idee einer Miniaturansicht, vielleicht beim Statustext, find ich spannend. Ich schau mal ob wir da was schlankes machen können:
|
In der Planneransicht selbst wäre es- neben aktivem aktuellen Slot- vllt auch schön, zu signalisieren wo der Plan endet. Dann könnte man sich sparen, weiter nach rechts zu scrollen. Also z.B. alle Slots die zwischen Plan Start/Ende liegen in dunklerem Grau oder hellem Grün? |
Das ist ja schon so :) |
Nächste Iteration- erstmal rein damit? |
Introduces a new UI to give users an insights what the target charge algorithm is doing. I opted for a reduced and simple visualisation. Its quite easy to create information overflow here and display every but our algorithm produces 😆.
I think these are reasonable tradeoffs that shouldn't affect day to day usage. But feel free do comment.
plan.mp4
You can play around with the UI at https://demo-next.evcc.io/
Please use the second loadpoint with the Model 3 for testing. The demo config seems to have planning issues with the first loadpoint.
Todos:
deal with tariffs that don't start/end on full hours=> something for a separate PRThanks @markusrem for the design sparring.