Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: disable via cli flag #17249

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Auth: disable via cli flag #17249

merged 6 commits into from
Nov 14, 2024

Conversation

naltatis
Copy link
Member

Add a --disable-auth flag to disable the authentication system. All requests will be treaded as admin user requests.

  • 👮 useful when running evcc behind a dedicated authentication layer (reverse proxy, ...)
  • 🏃‍♀️‍➡️ easier, when using evcc in an automated way (e.g. e2e tests, headless, ...)

\cc @panzerdev

@naltatis naltatis added the enhancement New feature or request label Nov 13, 2024
@naltatis naltatis requested a review from andig November 13, 2024 21:32
@andig andig added the needs documentation Triggers issue creation in evcc-io/docs label Nov 13, 2024
@panzerdev
Copy link
Contributor

panzerdev commented Nov 14, 2024

Thanks for considering my suggestion!

If there would be plans to add auth provider for SSO or others, maybe the flag could already be --auth-provider=none or --auth-provider=evccand later --auth-provider=google or so?

@naltatis
Copy link
Member Author

naltatis commented Nov 14, 2024

If there would be plans to add auth provider for SSO

Interesting idea. Right now I don't see the need to e.g. add multi-user support or integrate with other auth-systems since our primary focus is private use cases. Remote access might be a topic in the not so distant future, but I guess even then, we'll probably start with a private tunnel route and not necessarily integration with a public/external auth provider.

@panzerdev
Copy link
Contributor

panzerdev commented Nov 14, 2024

add multi-user support or integrate with other auth-systems since our primary focus is private use cases.

I am unsing google SSO for my private setup as an SSO provider to not have to think about auth. Thas's a private usecaes. In the end to the application it's the same JWT concept as now but the checking is done against the SSO provider.

A tunnel build into evcc seems way more overkill then having an sso that is easily setup.

@naltatis
Copy link
Member Author

I am unsing google SSO for my private setup as an SSO provider to not have to think about auth. Thas's a private usecaes.

I'd assume you're quite special in this regard, and not a lot of our user base does this. Let's postpone the auth provider discussion and focus on the option to disable here.

@naltatis naltatis marked this pull request as ready for review November 14, 2024 09:12
@naltatis naltatis removed the needs documentation Triggers issue creation in evcc-io/docs label Nov 14, 2024
@andig
Copy link
Member

andig commented Nov 14, 2024

Best way to do this is using an auth provider wirh Docker. No plans to rebuild this in evcc.

@andig andig merged commit 576cd71 into master Nov 14, 2024
6 checks passed
@andig andig deleted the feature/disable_auth branch November 14, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants