Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stats and gorm upgrade #15569

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fix: stats and gorm upgrade #15569

merged 2 commits into from
Aug 21, 2024

Conversation

naltatis
Copy link
Member

fixes #15472

  • 🆙 gorm upgrade
  • 🧹 simplify sql query code
  • ✅ reenabled skipped tests (not sure why they were disabled)

The actual issue with the gorm update was a behaviour change in .Scan which we call multiple times with the same reference for populating different parts of the result. Switched to single value assignment to circumvent this.

@andig
Copy link
Member

andig commented Aug 21, 2024

The actual issue with the gorm update was a behaviour change in .Scan which we call multiple times with the same reference for populating different parts of the result

Thats unexpected for a bugfix release. Is this documented or did you open an issue?

@naltatis
Copy link
Member Author

Thats unexpected for a bugfix release. Is this documented or did you open an issue?

No, just fixed our issue.

@andig
Copy link
Member

andig commented Aug 21, 2024

Wäre schön noch ein Issue aufzumachen- sonst ändert sich das demnächst wieder unerwartet zurück?

@naltatis
Copy link
Member Author

Das hier sieht aus wie die Änderung. Scheint, als ob das Resetting gewolltes Verhalten ist.
go-gorm/gorm#7061

@andig andig merged commit 4a49b04 into master Aug 21, 2024
6 checks passed
@andig andig deleted the fix/gorm_stats branch August 21, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading to gorm 1.25.11 breaks tests
2 participants