Skip to content

Fixed issue #93 #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixed issue #93 #247

wants to merge 2 commits into from

Conversation

darrengriffinhut42
Copy link

No description provided.

@LinusU
Copy link
Collaborator

LinusU commented Jul 29, 2019

Could you edit the source file instead of the compiled file?

Also, I know see what the problem is more clearly. Could you make sure that all +? are replaced with *? That includes the change you made, so that it is removing the ? as well.

Thanks 👋

@darrengriffinhut42
Copy link
Author

@LinusU any eta on when this will get merged?

@LinusU
Copy link
Collaborator

LinusU commented Jul 30, 2019

Could you change *? to just *, and remove the changes to the compiled files?

LinusU added a commit that referenced this pull request Jul 30, 2019
@LinusU
Tweak regex in retrieveSourceMapURL
4852362 
Fixes #93 
Closes #247 
Closes #248
@LinusU LinusU mentioned this pull request Jul 30, 2019
Merged
@LinusU LinusU closed this in #249 Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrengriffinhut42 @LinusU