Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Implement the Decorator Metadata proposal #3760

Closed
uinz opened this issue May 11, 2024 · 3 comments
Closed

Feature request: Implement the Decorator Metadata proposal #3760

uinz opened this issue May 11, 2024 · 3 comments

Comments

@uinz
Copy link

uinz commented May 11, 2024

I think esbuild should behave the same way as typescript when compiling decorators

ts playground
image

esbuild playground
image

@evanw
Copy link
Owner

evanw commented May 11, 2024

This looks like a feature request for https://github.com/tc39/proposal-decorator-metadata, which is a separate proposal from https://github.com/tc39/proposal-decorators.

@uinz
Copy link
Author

uinz commented May 11, 2024

This looks like a feature request for https://github.com/tc39/proposal-decorator-metadata, which is a separate proposal from https://github.com/tc39/proposal-decorators.

Thanks for your reply, you are right.
It was me who confused the two proposals.
esbuild is implemented for the tc39 standard.

@uinz uinz closed this as completed May 11, 2024
@evanw
Copy link
Owner

evanw commented May 12, 2024

Reopening this issue because it should probably still be implemented. I'm not sure why it's a separate proposal (e.g. if that means the committee is more unsure about it?) but TypeScript has already implemented and shipped it so it's not going away any time soon. I'm just not sure how ready it is to be implemented at the moment.

See also:

@evanw evanw reopened this May 12, 2024
@evanw evanw changed the title The decorators feature implemented in version 0.21 is missing metadata field Feature request: Implement the Decorator Metadata proposal May 12, 2024
@evanw evanw closed this as completed in 5e7cf25 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants