Improve Search Result Parsing / Show Errors In Web UI #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't mutate the line as we parse. It makes it difficult to reason about the current state. - Split each piece into a separate function that takes the original line and extracts only what we are looking for - Handle and add tests for special cases like when the file size isn't present. Fixes #41.
- Example: %F77FE9FF1CCD% - Look for the above format and remove it if present. - Fixes #42.
- Allow users to manually copy and paste the result string so they can still download the files. - When there are parse errors, a button appears at the top of the grid, allowing users to view all errors and the raw search result string in a separate errors grid. They can copy the search result manually to the top input box and click download.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
download string. There are always going to be edge cases that my parser can't deal with.
This solution will allow users to download any of the search results regardless of parsing
result.