Remove unnecessary stdout/stderr redirects

Author: JakubVanek

installer-jessie.sh

@@ -104,7 +104,7 @@ function do_help() {
 function do_native() {
     write_log "installing native libs"
     echo "Installing OpenCV and RXTX."
-    apt-get install --yes --no-install-recommends $LIB_PKGS 2>&1 || return $?
+    apt-get install --yes --no-install-recommends $LIB_PKGS  || return $?
 }
 
 ###########################################
@@ -155,20 +155,20 @@ function java_install_jri() {
     done
     rm -rf "$JRI_DIR" || true
 
-    wget -nv "$JRI_URL" -O /tmp/jri.tar.gz 2>&1 || return $?
+    wget -nv "$JRI_URL" -O /tmp/jri.tar.gz  || return $?
     tar -C /tmp -xf /tmp/jri.tar.gz
     mv /tmp/jri "$JRI_DIR"
 
     write_log "setting alternatives"
     for i in $(ls "$JRI_DIR/bin"); do
-        update-alternatives --install "/usr/bin/$i" "$i" "$JRI_DIR/bin/$i" "$JRI_PRIORITY" 2>&1
+        update-alternatives --install "/usr/bin/$i" "$i" "$JRI_DIR/bin/$i" "$JRI_PRIORITY"
     done
 
     JAVA_REAL_EXE="$(which java)"
     CLASSLIST="$JRI_CLASSLIST"
 
     write_log "dumping java cds"
-    "$JAVA_REAL_EXE" -Xshare:dump 2>&1
+    "$JAVA_REAL_EXE" -Xshare:dump
     return $?
 }
 
@@ -185,10 +185,10 @@ function java_install_ppa() {
 
     # add repo, update
     echo "$JDEB_REPO" | tee "/etc/apt/sources.list.d/jdk.list"
-    apt-get update 2>&1 || return $?
+    apt-get update  || return $?
 
     # install package
-    apt-get install --yes --no-install-recommends -t "$JDEB_REPO_NAME" $JDEB_PKGS 2>&1 || return $?
+    apt-get install --yes --no-install-recommends -t "$JDEB_REPO_NAME" $JDEB_PKGS  || return $?
 
     JAVA_REAL_EXE="$(which java)"
 }
@@ -201,7 +201,7 @@ function do_java_download() {
     echo "Downloading Java libraries..."
     rm -rf "$JAVA_LIBRARY_DIR"
     mkdir -p "$JAVA_LIBRARY_DIR"
-    wget -nv -N -P "$JAVA_LIBRARY_DIR" $JAVA_LIBRARY_LIST 2>&1
+    wget -nv -N -P "$JAVA_LIBRARY_DIR" $JAVA_LIBRARY_LIST
     return $?
 }
 
@@ -216,7 +216,7 @@ function do_fixup_perms() {
 function print_java() {
     echo
     echo "-> Java version:"
-    "$JAVA_REAL_EXE" -version 2>&1
+    "$JAVA_REAL_EXE" -version
 }
 
 # MAIN PROGRAM
@@ -231,7 +231,7 @@ if [ "$1" = "help" ] || [ "$1" = "-h" ] || [ "$1" = "--help" ]; then
 
 elif [ "$1" = "update" ]; then
     write_log "apt update"
-    apt-get update 2>&1
+    apt-get update
     exit $?
 
 elif [ "$1" = "java" ]; then

installer.sh

@@ -117,7 +117,7 @@ function do_help() {
 function do_native() {
     write_log "installing native libs"
     echo "Installing OpenCV and RXTX."
-    apt-get install --yes --no-install-recommends $LIB_PKGS 2>&1 || return $?
+    apt-get install --yes --no-install-recommends $LIB_PKGS  || return $?
 }
 
 ###########################################
@@ -163,7 +163,7 @@ function java_find() {
 function java_install_jri() {
     write_log "installing jri from ev3dev repo"
 
-    apt-get install --yes --no-install-recommends $JRI_PKGS 2>&1 || return $?
+    apt-get install --yes --no-install-recommends $JRI_PKGS  || return $?
 
     JAVA_REAL_EXE="$(which java)"
     CLASSLIST="$JRI_CLASSLIST"
@@ -185,10 +185,10 @@ function java_install_ppa() {
 
     # add repo, update
     echo "$JDEB_REPO" | tee "/etc/apt/sources.list.d/jdk.list"
-    apt-get update 2>&1 || return $?
+    apt-get update  || return $?
 
     # install package (the symlink above gets discarded, but it is needed during the installation)
-    apt-get install --yes --no-install-recommends -t "$JDEB_REPO_NAME" $JDEB_PKGS 2>&1 || return $?
+    apt-get install --yes --no-install-recommends -t "$JDEB_REPO_NAME" $JDEB_PKGS  || return $?
 
     JAVA_REAL_EXE="$(which java)"
 }
@@ -201,7 +201,7 @@ function do_java_download() {
     echo "Downloading Java libraries..."
     rm -rf "$JAVA_LIBRARY_DIR"
     mkdir -p "$JAVA_LIBRARY_DIR"
-    wget -nv -N -P "$JAVA_LIBRARY_DIR" $JAVA_LIBRARY_LIST 2>&1
+    wget -nv -N -P "$JAVA_LIBRARY_DIR" $JAVA_LIBRARY_LIST
     return $?
 }
 
@@ -231,7 +231,7 @@ function do_fixup_perms() {
 function print_java() {
     echo
     echo "-> Java version:"
-    "$JAVA_REAL_EXE" -version 2>&1
+    "$JAVA_REAL_EXE" -version
 }
 
 # MAIN PROGRAM
@@ -246,7 +246,7 @@ if [ "$1" = "help" ] || [ "$1" = "-h" ] || [ "$1" = "--help" ]; then
 
 elif [ "$1" = "update" ]; then
     write_log "apt update"
-    apt-get update 2>&1
+    apt-get update
     exit $?
 
 elif [ "$1" = "java" ]; then