Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell wrapper meson #40

Closed
noDGodiaev opened this issue Jul 26, 2021 · 3 comments
Closed

shell wrapper meson #40

noDGodiaev opened this issue Jul 26, 2021 · 3 comments

Comments

@noDGodiaev
Copy link
Collaborator

noDGodiaev commented Jul 26, 2021

Do we actually need a shell script?

before #29, it made sense. Playing with flags etc. Now it contains only 2 lines of build code and export PYTHONPATH.
Check noDGodiaev#1 for details.

The main question: for what purposes this script will be used?

  1. For developers: building package with one line - than the solution is done
  2. For CI dev tests to make them cleaner. I checked this:
    export PYTHONPATH inside script doesn't affect on run cell. (some Github Actions magic)
    So the solution: pytest cell can be moved into scripts.
  3. If @ev-br have any ideas, I can add them and check them.

That's my solution for now.

meson setup builddir --prefix=$PWD/installdir
meson install -C builddir
# Get python version for PYHTONPATH
ver=$(python -V 2>&1 | sed 's/.* \([0-9]\).\([0-9]\).*/\1.\2/')
export PYTHONPATH=$PWD/installdir/lib/python$ver/site-packages/
pytest mc_lib -v --pyargs
@ev-br
Copy link
Owner

ev-br commented Jul 26, 2021

It's definitely the first one. No need to keep fighting the gh actions. Some sort of script is certainly useful, even if only a convenience record for on-and-off users.

@ev-br
Copy link
Owner

ev-br commented Jul 27, 2021

Having mulled it over a bit, I think we should now merge in your current version. Mostly for documentation for the library --- the main usage is downstream, so we'll iterate based on that.

@ev-br
Copy link
Owner

ev-br commented Jul 28, 2021

all done: gh-41 is merged, README is updated in 6dfae32

@ev-br ev-br closed this as completed Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants