test: reconnect (reconnects forever)

Author: egasimus

index.js

@@ -306,10 +306,12 @@ export default class ChainlinkDataStreamsConsumer extends EventEmitter {
       if (this.ws) this.disconnectImpl();
       const ws = (this.ws = new WebSocket(url.toString(), { headers }));
       const onerror = (error) => {
+        console.error('Socket error:', error)
         unbind();
         resolve();
       };
       const onopen = () => {
+        console.debug('Socket opened.')
         unbind();
         // reset reconnect attempts on successful connection
         this.reconnect.attempts = 0;
@@ -320,6 +322,7 @@ export default class ChainlinkDataStreamsConsumer extends EventEmitter {
         ws.off('open', onopen);
       };
       const onclose = () => {
+        console.debug('Socket closed.')
         unbind();
         if (!this.reconnect?.enabled) {
           console.debug(
@@ -343,9 +346,7 @@ export default class ChainlinkDataStreamsConsumer extends EventEmitter {
             `Reconnecting attempt #${this.reconnect.attempts}/${this.reconnect.maxAttempts}`,
             `in ${this.reconnect.interval}ms...`,
           );
-          setTimeout(() => {
-            this.connectImpl();
-          }, this.reconnect.interval);
+          setTimeout(this.connectImpl, this.reconnect.interval);
         } else {
           const error =
             `Max reconnect attempts (${this.reconnect.maxAttempts}) reached. Giving up.`

test.js

@@ -1,6 +1,8 @@
 import ChainlinkDataStreamsConsumer, { Report } from './index.js';
 import assert from 'node:assert';
 import 'dotenv/config';
+import { WebSocket as _WebSocket } from 'ws';
+const WebSocket = _WebSocket || globalThis.WebSocket;
 
 const DEBUG = false;
 
@@ -369,6 +371,24 @@ describe('ChainlinkDataStreamsConsumer', function () {
     SDK.subscribeTo([]);
   });
 
+  it('should reconnect when socket closes', async function (done) {
+    this.timeout(10000);
+    const SDK = new ChainlinkDataStreamsConsumer({
+      ...config(),
+      feeds: feedIds,
+      lazy: true,
+    });
+    const connecting = await SDK.connect();
+    SDK.ws.close();
+    if (SDK.ws.readyState === WebSocket.CONNECTING) {
+      ws.once('open', () => {
+        done();
+      });
+    } else if (ws.readyState === WebSocket.OPEN) {
+      done()
+    }
+  });
+
   it('should throw an error when calling Report.fromSocketMessage with invalid data', function () {
     assert.throws(() => Report.fromSocketMessage({}), {
       name: 'Error',