BAEL-2338 #6150
Merged
BAEL-2338 #6150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reopening to retrigger build - looks like an openjdk key is missing |
KevinGilmore
requested changes
Mar 4, 2019
xml/src/main/java/com/baeldung/xmlhtml/helpers/jaxb/JAXBHelper.java
Outdated
Show resolved
Hide resolved
xml/src/main/java/com/baeldung/xmlhtml/helpers/jaxp/CustomHandler.java
Outdated
Show resolved
Hide resolved
xml/src/main/java/com/baeldung/xmlhtml/pojo/jaxb/html/elements/CustomElement.java
Outdated
Show resolved
Hide resolved
KevinGilmore
requested changes
Mar 11, 2019
xml/src/main/java/com/baeldung/xmlhtml/pojo/jaxb/html/ExampleHTML.java
Outdated
Show resolved
Hide resolved
xml/src/main/java/com/baeldung/xmlhtml/pojo/jaxb/html/ExampleHTML.java
Outdated
Show resolved
Hide resolved
|
@KevinGilmore - Thanks for the feedback - I prefer the explicit use of the otherwise optional XmlAccessorType but you are correct that it's unnecessary here and probably distracting. Removed and improved the formatting. Cheers! |
KevinGilmore
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.