This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
stream: fix stream not wanted bug #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradovic
reviewed
Feb 7, 2020
network/stream/stream.go
Outdated
| @@ -481,6 +481,7 @@ func (r *Registry) clientHandleOfferedHashes(ctx context.Context, p *Peer, msg * | |||
| if err := p.Send(ctx, wantedHashesMsg); err != nil { | |||
| protocols.Break(fmt.Errorf("sending empty wanted hashes: %w", err)) | |||
There was a problem hiding this comment.
return protocols.Break(fmt.Errorf("sending empty wanted hashes: %w", err)) ?
There was a problem hiding this comment.
Might be my bug, a leftover when I was introducing break errors 🙈
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where a stream that is no longer wanted would result in two
WantedHashesmessages sent to the upstream peer.Certain side effect observed is that the downstream peer would still try to seal the batch in any case, and this in turn causes some other data races on the server side.