-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect git tag commits #828
Comments
Ack! You're right! :( I'll fidget with the admin script tomorrow to figure out why and fix that. |
Looks like I'm not actually passing it in. Thanks. I'll add that for the next release. And figure out how easy it is to backfill the existing tags. |
The publish script has been updated and works. I'll get to the backfill script this week and correct all the old tags. Each tag will be updated to the latest version which has the given CHANGELOG entry present. |
The backfill script seems to have worked and I backfilled all the way back to when the changelog started. Let me know if you find any other problems. Thanks! :) |
I noticed that the release tags point to commits on
master
instead ofethers-v5-beta
.If you look here https://github.com/ethers-io/ethers.js/releases all of the tags point to the same
427e168
commit.The text was updated successfully, but these errors were encountered: