Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The XMLHttpRequest library is getting pulled in #789

Closed
ricmoo opened this issue Apr 18, 2020 · 4 comments
Closed

The XMLHttpRequest library is getting pulled in #789

ricmoo opened this issue Apr 18, 2020 · 4 comments

Comments

@ricmoo
Copy link
Member

ricmoo commented Apr 18, 2020

This causes problems in certain environments. See #506 for more details.

I thought originally it was a ws library issue, but it looks like it is coming from somewhere else.

Basically, it needs to be removed.

@ricmoo ricmoo added next version (v5) on-deck This Enhancement or Bug is currently being worked on. labels Apr 18, 2020
@ricmoo
Copy link
Member Author

ricmoo commented Apr 18, 2020

Heya @kamescg!

Can you check out these dist builds and see if what you need works?

I did a pretty major overhaul on the dist build scripts, so something else may break... Would be great to get some feedback before I publish. (CI is running right now anyways). :)

@kamescg
Copy link

kamescg commented Apr 22, 2020

Just seeing this now @ricmoo

Will run the distribution builds in a service worker environment today and let you know what happens.

@ricmoo ricmoo removed the on-deck This Enhancement or Bug is currently being worked on. label Apr 24, 2020
@ricmoo
Copy link
Member Author

ricmoo commented Apr 24, 2020

The list builds in 5.0.0-beta.183 should also have it now. :)

I'm going to close this, but please feel free to re-open if it is still an issue.

Thanks! :)

@ricmoo ricmoo closed this as completed Apr 24, 2020
@kamescg
Copy link

kamescg commented May 1, 2020

Just want to report and say I was able to get the latest working in the a service-worker. Thanks for the speedy update. As usual!

Picture for proof - listening on provider.on('block', event => ...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants