encrypt wallet with Mnemonic Spanish language

[elranu]

Hi,
I'm trying to encrypt a wallet created with Mnemonic in Spanish and I get some errors. The strange thing is that if I do it in English works perfect.
First I have tried the following code:

import { ethers } from 'ethers';
import { es } from 'ethers/wordlists';

private async all(){
    const randomBytes = ethers.utils.randomBytes(24);
    const mnemonic =  ethers.utils.HDNode.entropyToMnemonic(randomBytes, es);
    const wallet = ethers.Wallet.fromMnemonic(mnemonic, null, es);
    const json = await wallet.encrypt("123");
    return json;
  }

And I get the following error:

ERROR Error: Uncaught (in promise): Error: entropy and mnemonic mismatch
Error: entropy and mnemonic mismatch
    at Object.r.encrypt (ethers.min.js:1)
    at _.encrypt (ethers.min.js:1)
    at WalletService.<anonymous> (wallet.service.ts:81)
    at Generator.next (<anonymous>)
    at tslib.es6.js:73
    at new ZoneAwarePromise (zone-evergreen.js:876)
    at Module.__awaiter (tslib.es6.js:69)
    at WalletService.all (wallet.service.ts:76)
    at WalletService.<anonymous> (wallet.service.ts:46)
    at Generator.next (<anonymous>)
    at resolvePromise (zone-evergreen.js:797)
    at zone-evergreen.js:707
    at rejected (tslib.es6.js:71)
    at ZoneDelegate.invoke (zone-evergreen.js:359)
    at Object.onInvoke (core.js:39699)
    at ZoneDelegate.invoke (zone-evergreen.js:358)
    at Zone.run (zone-evergreen.js:124)
    at zone-evergreen.js:855
    at ZoneDelegate.invokeTask (zone-evergreen.js:391)
    at Object.onInvokeTask (core.js:39680)

The second code I have tried is:

 private async all(){
    const randomBytes = ethers.utils.randomBytes(24);
    const mnemonic =  ethers.utils.HDNode.entropyToMnemonic(randomBytes, es);
    const entropy = ethers.utils.HDNode.mnemonicToEntropy(mnemonic, es);
    const wallet = ethers.Wallet.fromMnemonic(mnemonic, null, es);
    const json = await wallet.encrypt("123", {entropy: entropy}); 
    return json;
  }

and I get the following error:

ERROR Error: Uncaught (in promise): Error: entropy and mnemonic mismatch
Error: entropy and mnemonic mismatch
    at Object.r.encrypt (ethers.min.js:1)
    at _.encrypt (ethers.min.js:1)
    at WalletService.<anonymous> (wallet.service.ts:81)
    at Generator.next (<anonymous>)
    at tslib.es6.js:73
    at new ZoneAwarePromise (zone-evergreen.js:876)
    at Module.__awaiter (tslib.es6.js:69)
    at WalletService.all (wallet.service.ts:76)
    at WalletService.<anonymous> (wallet.service.ts:46)
    at Generator.next (<anonymous>)
    at resolvePromise (zone-evergreen.js:797)
    at zone-evergreen.js:707
    at rejected (tslib.es6.js:71)
    at ZoneDelegate.invoke (zone-evergreen.js:359)
    at Object.onInvoke (core.js:39699)
    at ZoneDelegate.invoke (zone-evergreen.js:358)
    at Zone.run (zone-evergreen.js:124)
    at zone-evergreen.js:855
    at ZoneDelegate.invokeTask (zone-evergreen.js:391)
    at Object.onInvokeTask (core.js:39680)

What I'm doing wrong???
Thanks in advance :)

[ricmoo]

I have a feeling this may be a bug, but I'll need to investigate. Your code looks correct to me.

I'll investigate tomorrow as today has been 10 hours of writing documentation and my brain is mushy. :)

[ricmoo]

I've confirmed this is an issue in v4 and v5. I am trying to figure out a backwards-compatible fix that is safe.

Since v5 is not officially released yet, backwards compatibility isn't as important, so I may fix it there first to try out a few ideas.

I'll keep this ticket updated and sorry for the inconvenience.

[elranu]

Ok, Thank you!

[elranu]

Hi any news? Can I help you with something, a PR? just give me explain me where to touch I'll do it.

[ricmoo]

Hiya!

Sorry for the delay. There is not a clean way to solve it in v4 without breaking backwards compatibility, but there is a way I can fix it that is a bit cumbersome to use, but will work. I'll put that into v4 and solve it more completely in v5.

Are you using v4 or v5?

[elranu]

Hi,
I'm using version 4. But I'm in time to change versions, how stable is version 5? Do yo have an estimated for the release?

[ricmoo]

I was hoping to have a stable release this month, but it is looking like it will likely be next month...

[elranu]

Hi,
Sorry for asking you again. I know that you ar fixing it on v5, but of 4 will be a way to solve it meanwhile? Because you mentioned a cumbersome fix, so if you can share that code it will be great for me.

[ricmoo]

Yeah, I will probably put the non-ideal fix in for v4. In v5 I've already abstracted the mnemonic out so it will work better. I just haven't put the mnemonic locale into the x-ethers extension for JSON wallets yet. Sorry for the delay, I'll get something for you soon. It may be some code you can cut and paste, but it will be something. :)