-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poll is not exported from utils/index.ts #512
Comments
I should probably add I don't think you should need to fork the project though, you can always |
I won't need to fork it :) I need tree-shaking (reduces a script from 2.7MB to 355k), and so in that context, the only export available is |
That is coming in the future too, but is quite hard to support in the current JavaScript landscape, since to support ES3 through ES6 and also browser + Node + others, the tooling is weird. But I have some ideas I'm working on. :) 2.7MB is huge, though? The ethers.js library, under 300kb uncompressed (and about 82kb over-the-wire). But v5 can partially solve this as well, since everything is broken out into packages, so you can pick and choose what you need, and with smaller packages, the |
oh yes! the majority of the 2.7MB comes from the json of 3 deployed contracts we distribute, which is why I need tree-shaking :). Thanks for everything! When will v5 source be in a branch here on github? (not to pressure you, I just want to see it) |
Have you tried using Human-Readable ABI? It is generally significantly more compact, and results in easier to read code. :) In v5, the libraries are exposed to convert between JSON ABI and Human-Readable ABI can help automate a lot of this. :) |
https://github.com/unlock-protocol/unlock/blob/master/unlock-js/scripts/compressAbi.js yep :) I look forward to converting my multi-line |
Poll is now exported in Thanks! :) |
Because of this, #511 cannot be fixed without forking the project.
The text was updated successfully, but these errors were encountered: