Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow storage-class in Human-Readable ABI #476

Closed
ricmoo opened this issue Mar 27, 2019 · 1 comment
Closed

Feature: allow storage-class in Human-Readable ABI #476

ricmoo opened this issue Mar 27, 2019 · 1 comment
Assignees
Labels
enhancement New feature or improvement.

Comments

@ricmoo
Copy link
Member

ricmoo commented Mar 27, 2019

The Human-Readable ABI currently does not allow storage-class in a fragment, which may mean the signature cannot be directly copied from the Solidity.

For example, this should work fine:

const abi = [
    "function foo(string memory bar)"
];

However, the memory and storage keywords are not supported by the parser. It is a simple state transition required when reading a space, to check in the same way the keyword indexed is processed, which can discard the name and revert the parser state back to allowName.

@ricmoo ricmoo added enhancement New feature or improvement. next version labels Mar 27, 2019
@ricmoo ricmoo self-assigned this Mar 27, 2019
@ricmoo
Copy link
Member Author

ricmoo commented May 24, 2019

Added! :)

@ricmoo ricmoo closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement.
Projects
None yet
Development

No branches or pull requests

1 participant