lib/etherscan_provider.ts doesn't accept API key

[Divide-By-0]

Note: Not all sections may be relevant, but please be as thorough while remaining concise as possible. Remove this Notice and any sections that don't feel pertinent.

If you are unsure if something is a bug, start a thread in the "discussions" tab above..

Describe the bug
I provide a defaultProvider object with all 4 API keys. However, the lib/etherscan_provider.ts file still prints a warning when executing a transaction (const response = await fromEthWallet.sendTransaction(tx);)

========= NOTICE =========
Request-Rate Exceeded  (this message will not be repeated)

The default API keys for each service are provided as a highly-throttled,
community resource for low-traffic projects and early prototyping.

While your application will continue to function, we highly recommended
signing up for your own API keys to improve performance, increase your
request rate/limit and enable other perks, such as metrics and advanced APIs.

For more details: https://docs.ethers.io/api-keys/
==========================

meaning the API key doesn't work, although I copied it directly from Etherscan (it also shows 0 calls on etherscan). I put a print statement right before this message, and that is repeatedly printed from the same place as the code constantly retries.

Reproduction steps
As above.

Environment:
Running code with: npx --node-options='--trace-sigint' ts-node test.ts 2>&1 | tee -a log.out

Here is my relevant package.json:

  "dependencies": {
    "@alch/alchemy-web3": "^1.1.1",
    "ethers": "^5.4.1",
    "readline": "^1.3.0",
    "ts-node": "^10.1.0",
    "tslib": "^2.3.0",
    "typescript": "^4.3.5",
    "web3": "^1.4.0",
  },
  "devDependencies": {
    "@types/node": "^16.4.1",
    "hardhat": "^2.4.3",
    "nodemon": "^2.0.12"
  }

On desktop.

Search Terms
N/A

[ricmoo]

Can you include the code you use when calling getDefaultProvider? You can redact your API keys, but leave the structure.

Also, there should not be any lib/etherscan_provider.ts file. Where did you get that filename from?

[NiftyAndy]

Noticing the same issue. Looks like the Etherscan API key from options was commented out for some reason

ethers.js/packages/networks/src.ts/index.ts

Lines 35 to 49 in da4e107

	if (providers.EtherscanProvider) {
	//try {
	// providerList.push(new providers.EtherscanProvider(network, options.etherscan));
	//} catch(error) { }
	// These networks are currently faulty on this provider
	// @TODO: This goes away once they have fixed their nodes
	const skip = [ "ropsten" ];
	try {
	const provider = new providers.EtherscanProvider(network);
	if (provider.network && skip.indexOf(provider.network.name) === -1) {
	providerList.push(provider);
	}
	} catch(error) { }
	}

[ricmoo]

Interesting. I’ll look into this right away. Thanks for checking deeper into it. :)

[ricmoo]

This should be fixed in 5.4.4. Please try it out and let me know if you have any issues.

Thanks! :)