Merge pull request #230 from etherfi-protocol/v2.49

V2.49

Author: seongyun-ko

.gitmodules

@@ -22,3 +22,6 @@
 [submodule "lib/eigenlayer-contracts"]
 	path = lib/eigenlayer-contracts
 	url = https://github.com/Layr-Labs/eigenlayer-contracts
+[submodule "lib/solady"]
+	path = lib/solady
+	url = https://github.com/Vectorized/solady

audits/2025.01.23 - Certora - EtherFi - Withdrawal Fee.pdf

@@ -0,0 +1,10 @@
+{
+  "EtherFiRedemptionManagerImplementation": "0xe6f40295A7500509faD08E924c91b0F050a7b84b",
+  "EtherFiRedemptionManagerInstance": "0xDadEf1fFBFeaAB4f68A9fD181395F68b4e4E7Ae0",
+  "EtherFiAdminImplementation": "0x683583979C8be7Bcfa41E788Ab38857dfF792f49",
+  "EtherFiRewardsRouterImplementation": "0xe94bF0DF71002ff0165CF4daB461dEBC3978B0fa",
+  "LiquidityPoolImplementation": "0xA6099d83A67a2c653feB5e4e48ec24C5aeE1C515",
+  "WeETHImplementation": "0x353E98F34b6E5a8D9d1876Bf6dF01284d05837cB",
+  "WithdrawRequestNFTImplementation": "0x685870a508b56c7f1002EEF5eFCFa01304474F61",
+  "EtherFiNodesManagerImplementation": "0x572E25fD70b6eB9a3CaD1CE1D48E3CfB938767F1"
+}

deployment/deployed-contracts.json

@@ -2,13 +2,16 @@
 src = 'src'
 out = 'out'
 libs = ['lib']
-fs_permissions = [{ access = "read-write", path = "./release"}, { access = "read", path = "./test" }]
+fs_permissions = [{ access = "read-write", path = "./release"}, { access = "read", path = "./test" }, { access = "read-write", path = "./operations" },  { access = "read-write", path = "./deployment" }]
 gas_reports = ["*"]
 optimizer_runs = 2000
 extra_output = ["storageLayout"]
 bytecode_hash = 'none'
 solc-version = '0.8.24'
 
+[fuzz]
+max_shrink_iters = 100
+
 # See more config options https://github.com/foundry-rs/foundry/tree/master/config
 [rpc_endpoints]
 mainnet = "${MAINNET_RPC_URL}"

foundry.toml

@@ -71,6 +71,11 @@ library BucketLimiter {
         return limit.remaining >= amount;
     }
 
+    function consumable(Limit memory limit) external view returns (uint64) {
+        _refill(limit);
+        return limit.remaining;
+    }
+
     /*
      * Consumes the given amount from the bucket, if there is sufficient capacity, and returns
      * whether the bucket had enough remaining capacity to consume the amount.
@@ -104,18 +109,22 @@ library BucketLimiter {
     }
 
     function _refill(Limit memory limit) internal view {
-        // We allow for overflow here, as the delta is resilient against it.
         uint64 now_ = uint64(block.timestamp);
-        uint64 delta;
+
+        if (now_ == limit.lastRefill) {
+            return;
+        }
+
+        uint256 delta;
         unchecked {
             delta = now_ - limit.lastRefill;
         }
-        uint64 tokens = delta * limit.refillRate;
-        uint64 newRemaining = limit.remaining + tokens;
+        uint256 tokens = delta * uint256(limit.refillRate);
+        uint256 newRemaining = uint256(limit.remaining) + tokens;
         if (newRemaining > limit.capacity) {
             limit.remaining = limit.capacity;
         } else {
-            limit.remaining = newRemaining;
+            limit.remaining = uint64(newRemaining);
         }
         limit.lastRefill = now_;
     }
@@ -157,4 +166,4 @@ library BucketLimiter {
         refill(limit);
         limit.remaining = remaining;
     }
-}
+}

lib/BucketLimiter.sol

@@ -0,0 +1,11 @@
+{
+  "chainId": "1",
+  "meta": { "txBuilderVersion": "1.16.5" },
+  "transactions": [
+    {
+      "to": "0x9f26d4c958fd811a1f59b01b86be7dffc9d20761",
+      "value": "0",
+      "data": "0xe38335e500000000000000000000000000000000000000000000000000000000000000a000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000160000000000000000000000000000000000000000000000000000000000000000012cd17fdc855070e6b92a85ee62b7b5f78b031a423542fabd5d0ace52bdd8aea00000000000000000000000000000000000000000000000000000000000000020000000000000000000000007d5706f6ef3f89b3951e23e557cdfbc3239d4e2c000000000000000000000000308861a430be4cce5502d0a12724771fc6daf21600000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000014000000000000000000000000000000000000000000000000000000000000000c44f1ef28600000000000000000000000078f424c42f006b046b927d49b6d7abef74ca67ae00000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000044f8a025b40000000000000000000000009af1298993dc1f397973c62a5d47a284cf76844d0000000000000000000000000000000000000000000000000000000000001388000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000a44f1ef286000000000000000000000000a05d566bac16e2fbcec4cff68e89119ee2a96ef900000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000024984856a3000000000000000000000000d5fd46f4df70a63d60a8563cad0444fcc25dce7f0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"
+    }
+  ]
+}

lib/solady

@@ -0,0 +1,11 @@
+{
+  "chainId": "1",
+  "meta": { "txBuilderVersion": "1.16.5" },
+  "transactions": [
+    {
+      "to": "0x9f26d4c958fd811a1f59b01b86be7dffc9d20761",
+      "value": "0",
+      "data": "0x8f2a0bb000000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000001200000000000000000000000000000000000000000000000000000000000000180000000000000000000000000000000000000000000000000000000000000000012cd17fdc855070e6b92a85ee62b7b5f78b031a423542fabd5d0ace52bdd8aea000000000000000000000000000000000000000000000000000000000003f48000000000000000000000000000000000000000000000000000000000000000020000000000000000000000007d5706f6ef3f89b3951e23e557cdfbc3239d4e2c000000000000000000000000308861a430be4cce5502d0a12724771fc6daf21600000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000014000000000000000000000000000000000000000000000000000000000000000c44f1ef28600000000000000000000000078f424c42f006b046b927d49b6d7abef74ca67ae00000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000044f8a025b40000000000000000000000009af1298993dc1f397973c62a5d47a284cf76844d0000000000000000000000000000000000000000000000000000000000001388000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000a44f1ef286000000000000000000000000a05d566bac16e2fbcec4cff68e89119ee2a96ef900000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000024984856a3000000000000000000000000d5fd46f4df70a63d60a8563cad0444fcc25dce7f0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"
+    }
+  ]
+}

operations/20250128_upgrade_instant_withdrawal_execute.json

@@ -0,0 +1,5 @@
+{
+  "data": "0x134008d300000000000000000000000062247d29b4b9becf4bb73e0c722cf6445cfc7ce9000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000a000000000000000000000000000000000000000000000000000000000000000000bd6d9e322298e0f92aa3165320fd6b939206883bdacb1d807c09161ab0cef9e000000000000000000000000000000000000000000000000000000000000000479ba509700000000000000000000000000000000000000000000000000000000",
+  "to": "0x9f26d4C958fD811A1F59B01B86Be7dFFc9d20761",
+  "value": 0
+}

operations/20250128_upgrade_instant_withdrawal_schedule.json

@@ -0,0 +1,5 @@
+{
+  "data": "0x01d5062a00000000000000000000000062247d29b4b9becf4bb73e0c722cf6445cfc7ce9000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000000000bd6d9e322298e0f92aa3165320fd6b939206883bdacb1d807c09161ab0cef9e000000000000000000000000000000000000000000000000000000000003f480000000000000000000000000000000000000000000000000000000000000000479ba509700000000000000000000000000000000000000000000000000000000",
+  "to": "0x9f26d4C958fD811A1F59B01B86Be7dFFc9d20761",
+  "value": 0
+}