Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm/tx: update 7702 to devnet-4 #3737

Draft
wants to merge 12 commits into
base: devnet4-contracts
Choose a base branch
from

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented Oct 10, 2024

This PR addresses the following EIP PRs for devnet-4 :

ethereum/EIPs#8845 (removes the secp256k1/2 check of s of an authority tuple)
ethereum/EIPs#8938 (do not allow the nonce of an authority tuple to be 2^64 - 1 (NOTE: the check that it is less-than-or-equal-to 2^64 - 1 is done at the tx level (such that it fits within an uint64), but this check makes it explicit that the authority nonce is not 2^64 - 1, because bumping this nonce would make it 2^64, thus not fitting within an uint64 anymore)
ethereum/EIPs#8929 (revokes delegation mechanism, changes yParity validity at tx-level to fit within a uint8 / bytes1)
ethereum/EIPs#8948 (increases PER_AUTH_BASE_COST, the fee paid when delegating an authority account which already exists in the trie)

Note: descriptions of this PR might look incomplete when checking these individual PRs, however this means that that specific change has been overridden by a newer PR. For devnet-4 this is also included: ethereum/EIPs#8940, however this does not change anything and is just clarifications.

This PR points to (and builds upon) #3706. (I would like to use that PR as devnet-4 base branch)

TODOs

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (devnet4-contracts@1b65e0c). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
wallet 0.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant